Code Review
/
holmes
/
common.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Trying to fix the XSS problem
[holmes/common.git]
/
holmes-actions
/
src
/
test
/
java
/
org
/
onap
/
holmes
/
common
/
utils
/
transactionid
/
TransactionIdFilterTest.java
diff --git
a/holmes-actions/src/test/java/org/onap/holmes/common/utils/transactionid/TransactionIdFilterTest.java
b/holmes-actions/src/test/java/org/onap/holmes/common/utils/transactionid/TransactionIdFilterTest.java
index
3ef092e
..
cfbf747
100644
(file)
--- a/
holmes-actions/src/test/java/org/onap/holmes/common/utils/transactionid/TransactionIdFilterTest.java
+++ b/
holmes-actions/src/test/java/org/onap/holmes/common/utils/transactionid/TransactionIdFilterTest.java
@@
-1,5
+1,5
@@
/**
/**
- * Copyright 2018 ZTE Corporation.
+ * Copyright 2018
- 2021
ZTE Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@
-38,11
+38,13
@@
public class TransactionIdFilterTest {
responseMock = EasyMock.createMock(HttpServletResponse.class);
chainMock = EasyMock.createMock(FilterChain.class);
}
responseMock = EasyMock.createMock(HttpServletResponse.class);
chainMock = EasyMock.createMock(FilterChain.class);
}
+
@Test
public void callsChainDoFilter() throws Exception {
filter.doFilter(requestMock, responseMock, chainMock);
EasyMock.verify();
}
@Test
public void callsChainDoFilter() throws Exception {
filter.doFilter(requestMock, responseMock, chainMock);
EasyMock.verify();
}
+
@Test
public void requestIdExistTest() throws Exception{
String requestID = TransactionIdUtils.getUUID();
@Test
public void requestIdExistTest() throws Exception{
String requestID = TransactionIdUtils.getUUID();
@@
-51,8
+53,15
@@
public class TransactionIdFilterTest {
EasyMock.replay(requestMock);
filter.doFilter(requestMock, responseMock, chainMock);
EasyMock.verify();
EasyMock.replay(requestMock);
filter.doFilter(requestMock, responseMock, chainMock);
EasyMock.verify();
-
}
}
+ @Test
+ public void requestIdInvalidRerquestId() throws Exception{
+ String requestID = "TransactionIdUtils.getUUID()";
+ EasyMock.expect(requestMock.getHeader(TransactionIdUtils.REQUEST_ID_HEADER)).andReturn(requestID);
+ EasyMock.replay(requestMock);
+ filter.doFilter(requestMock, responseMock, chainMock);
+ EasyMock.verify();
+ }
}
\ No newline at end of file
}
\ No newline at end of file