Code Review
/
holmes
/
common.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Added DB Query for Legacy Engine Instances
[holmes/common.git]
/
holmes-actions
/
src
/
test
/
java
/
org
/
onap
/
holmes
/
common
/
engine
/
service
/
impl
/
EngineEntityServiceImplTest.java
diff --git
a/holmes-actions/src/test/java/org/onap/holmes/common/engine/service/impl/EngineEntityServiceImplTest.java
b/holmes-actions/src/test/java/org/onap/holmes/common/engine/service/impl/EngineEntityServiceImplTest.java
index
7058943
..
21a4025
100644
(file)
--- a/
holmes-actions/src/test/java/org/onap/holmes/common/engine/service/impl/EngineEntityServiceImplTest.java
+++ b/
holmes-actions/src/test/java/org/onap/holmes/common/engine/service/impl/EngineEntityServiceImplTest.java
@@
-24,10
+24,7
@@
import org.onap.holmes.common.engine.entity.EngineEntity;
import org.onap.holmes.common.engine.service.EngineEntityService;
import org.onap.holmes.common.utils.DbDaoUtil;
import org.onap.holmes.common.engine.service.EngineEntityService;
import org.onap.holmes.common.utils.DbDaoUtil;
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
import static com.google.common.base.Predicates.notNull;
import static org.hamcrest.core.Is.is;
import static com.google.common.base.Predicates.notNull;
import static org.hamcrest.core.Is.is;
@@
-35,9
+32,14
@@
import static org.hamcrest.core.IsNull.notNullValue;
import static org.junit.Assert.*;
public class EngineEntityServiceImplTest {
import static org.junit.Assert.*;
public class EngineEntityServiceImplTest {
-
private EngineEntityService service = new EngineEntityServiceImpl(new DbDaoUtilStub());
private EngineEntityService service = new EngineEntityServiceImpl(new DbDaoUtilStub());
+ @Test
+ public void getLegacyEngines() {
+ List<String> legacyEngines = service.getLegacyEngines();
+ assertThat(legacyEngines.size(), is(2));
+ }
+
@Test
public void getEntity() throws Exception {
EngineEntity entity = service.getEntity("org.onap.holmes_9201");
@Test
public void getEntity() throws Exception {
EngineEntity entity = service.getEntity("org.onap.holmes_9201");
@@
-102,6
+104,11
@@
class EngineEntityDaoStub implements EngineEntityDao {
return new ArrayList<>(entitySet);
}
return new ArrayList<>(entitySet);
}
+ @Override
+ public List<String> getLegacyEngines() {
+ return Arrays.asList("org.onap.holmes", "org.onap.holmes.legacy.1");
+ }
+
@Override
public void insertEntity(EngineEntity entity) {
entitySet.add(entity);
@Override
public void insertEntity(EngineEntity entity) {
entitySet.add(entity);