Code Review
/
dmaap
/
datarouter.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix Group Vulnerabilities
[dmaap/datarouter.git]
/
datarouter-prov
/
src
/
main
/
java
/
org
/
onap
/
dmaap
/
datarouter
/
provisioning
/
beans
/
Group.java
diff --git
a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
index
91d6c1b
..
3536309
100644
(file)
--- a/
datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
+++ b/
datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/Group.java
@@
-106,7
+106,7
@@
public class Group extends Syncable {
}
\r
db.release(conn);
\r
} catch (SQLException e) {
\r
}
\r
db.release(conn);
\r
} catch (SQLException e) {
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
return list;
\r
}
\r
}
\r
return list;
\r
}
\r
@@
-127,7
+127,7
@@
public class Group extends Syncable {
db.release(conn);
\r
} catch (SQLException e) {
\r
intlogger.info("getMaxSubID: " + e.getMessage());
\r
db.release(conn);
\r
} catch (SQLException e) {
\r
intlogger.info("getMaxSubID: " + e.getMessage());
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
return max;
\r
}
\r
}
\r
return max;
\r
}
\r
@@
-150,7
+150,7
@@
public class Group extends Syncable {
}
\r
db.release(conn);
\r
} catch (SQLException e) {
\r
}
\r
db.release(conn);
\r
} catch (SQLException e) {
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
return list;
\r
}
\r
}
\r
return list;
\r
}
\r
@@
-176,7
+176,7
@@
public class Group extends Syncable {
db.release(conn);
\r
} catch (SQLException e) {
\r
intlogger.warn("PROV0008 countActiveSubscriptions: " + e.getMessage());
\r
db.release(conn);
\r
} catch (SQLException e) {
\r
intlogger.warn("PROV0008 countActiveSubscriptions: " + e.getMessage());
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
return count;
\r
}
\r
}
\r
return count;
\r
}
\r
@@
-346,14
+346,14
@@
public class Group extends Syncable {
} catch (SQLException e) {
\r
rv = false;
\r
intlogger.warn("PROV0005 doInsert: " + e.getMessage());
\r
} catch (SQLException e) {
\r
rv = false;
\r
intlogger.warn("PROV0005 doInsert: " + e.getMessage());
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
} finally {
\r
try {
\r
if(ps!=null) {
\r
ps.close();
\r
}
\r
} catch (SQLException e) {
\r
} finally {
\r
try {
\r
if(ps!=null) {
\r
ps.close();
\r
}
\r
} catch (SQLException e) {
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
}
\r
return rv;
\r
}
\r
}
\r
return rv;
\r
@@
-376,14
+376,14
@@
public class Group extends Syncable {
} catch (SQLException e) {
\r
rv = false;
\r
intlogger.warn("PROV0006 doUpdate: " + e.getMessage());
\r
} catch (SQLException e) {
\r
rv = false;
\r
intlogger.warn("PROV0006 doUpdate: " + e.getMessage());
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
} finally {
\r
try {
\r
if(ps!=null) {
\r
ps.close();
\r
}
\r
} catch (SQLException e) {
\r
} finally {
\r
try {
\r
if(ps!=null) {
\r
ps.close();
\r
}
\r
} catch (SQLException e) {
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
}
\r
return rv;
\r
}
\r
}
\r
return rv;
\r
@@
-401,14
+401,14
@@
public class Group extends Syncable {
} catch (SQLException e) {
\r
rv = false;
\r
intlogger.warn("PROV0007 doDelete: " + e.getMessage());
\r
} catch (SQLException e) {
\r
rv = false;
\r
intlogger.warn("PROV0007 doDelete: " + e.getMessage());
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
} finally {
\r
try {
\r
if(ps!=null) {
\r
ps.close();
\r
}
\r
} catch (SQLException e) {
\r
} finally {
\r
try {
\r
if(ps!=null) {
\r
ps.close();
\r
}
\r
} catch (SQLException e) {
\r
-
e.printStackTrace(
);
\r
+
intlogger.error("SQLException " + e.getMessage()
);
\r
}
\r
}
\r
return rv;
\r
}
\r
}
\r
return rv;
\r