Code Review
/
dmaap
/
datarouter.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Checkstyle fixes for datarouter prov
[dmaap/datarouter.git]
/
datarouter-prov
/
src
/
main
/
java
/
org
/
onap
/
dmaap
/
datarouter
/
provisioning
/
LogServlet.java
diff --git
a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/LogServlet.java
b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/LogServlet.java
index
e3b9c57
..
0bea9f4
100644
(file)
--- a/
datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/LogServlet.java
+++ b/
datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/LogServlet.java
@@
-24,6
+24,10
@@
\r
package org.onap.dmaap.datarouter.provisioning;
\r
\r
\r
package org.onap.dmaap.datarouter.provisioning;
\r
\r
+import static org.onap.dmaap.datarouter.provisioning.utils.HttpServletUtils.sendResponseError;
\r
+
\r
+import com.att.eelf.configuration.EELFLogger;
\r
+import com.att.eelf.configuration.EELFManager;
\r
import java.io.IOException;
\r
import java.sql.Connection;
\r
import java.sql.ResultSet;
\r
import java.io.IOException;
\r
import java.sql.Connection;
\r
import java.sql.ResultSet;
\r
@@
-34,7
+38,6
@@
import java.text.SimpleDateFormat;
import java.util.Date;
\r
import java.util.HashMap;
\r
import java.util.Map;
\r
import java.util.Date;
\r
import java.util.HashMap;
\r
import java.util.Map;
\r
-
\r
import javax.servlet.ServletOutputStream;
\r
import javax.servlet.http.HttpServletRequest;
\r
import javax.servlet.http.HttpServletResponse;
\r
import javax.servlet.ServletOutputStream;
\r
import javax.servlet.http.HttpServletRequest;
\r
import javax.servlet.http.HttpServletResponse;
\r
@@
-49,10
+52,9
@@
import org.onap.dmaap.datarouter.provisioning.eelf.EelfMsgs;
import org.onap.dmaap.datarouter.provisioning.utils.DB;
\r
import org.onap.dmaap.datarouter.provisioning.utils.LOGJSONObject;
\r
\r
import org.onap.dmaap.datarouter.provisioning.utils.DB;
\r
import org.onap.dmaap.datarouter.provisioning.utils.LOGJSONObject;
\r
\r
-import com.att.eelf.configuration.EELFLogger;
\r
-import com.att.eelf.configuration.EELFManager;
\r
\r
\r
-import static org.onap.dmaap.datarouter.provisioning.utils.HttpServletUtils.sendResponseError;
\r
+
\r
+
\r
\r
/**
\r
* This servlet handles requests to the <feedLogURL> and <subLogURL>,
\r
\r
/**
\r
* This servlet handles requests to the <feedLogURL> and <subLogURL>,
\r
@@
-62,6
+64,7
@@
import static org.onap.dmaap.datarouter.provisioning.utils.HttpServletUtils.send
* @version $Id: LogServlet.java,v 1.11 2014/03/28 17:27:02 eby Exp $
\r
*/
\r
@SuppressWarnings("serial")
\r
* @version $Id: LogServlet.java,v 1.11 2014/03/28 17:27:02 eby Exp $
\r
*/
\r
@SuppressWarnings("serial")
\r
+
\r
public class LogServlet extends BaseServlet {
\r
//Adding EELF Logger Rally:US664892
\r
private static EELFLogger eelfLogger = EELFManager.getInstance().getLogger(LogServlet.class);
\r
public class LogServlet extends BaseServlet {
\r
//Adding EELF Logger Rally:US664892
\r
private static EELFLogger eelfLogger = EELFManager.getInstance().getLogger(LogServlet.class);
\r
@@
-82,11
+85,22
@@
public class LogServlet extends BaseServlet {
private final String[] fields;
\r
private boolean firstrow;
\r
\r
private final String[] fields;
\r
private boolean firstrow;
\r
\r
- public RowHandler(ServletOutputStream out, String fieldparam, boolean b) {
\r
+ /**
\r
+ * Row setter.
\r
+ * @param out ServletOutputStream
\r
+ * @param fieldparam String field
\r
+ * @param bool boolean
\r
+ */
\r
+ public RowHandler(ServletOutputStream out, String fieldparam, boolean bool) {
\r
this.out = out;
\r
this.out = out;
\r
- this.firstrow = b;
\r
+ this.firstrow = b
ool
;
\r
this.fields = (fieldparam != null) ? fieldparam.split(":") : null;
\r
}
\r
this.fields = (fieldparam != null) ? fieldparam.split(":") : null;
\r
}
\r
+
\r
+ /**
\r
+ * Handling row from DB.
\r
+ * @param rs DB Resultset
\r
+ */
\r
public void handleRow(ResultSet rs) {
\r
try {
\r
LOGJSONable js = buildJSONable(rs);
\r
public void handleRow(ResultSet rs) {
\r
try {
\r
LOGJSONable js = buildJSONable(rs);
\r
@@
-95,44
+109,52
@@
public class LogServlet extends BaseServlet {
// filter out unwanted fields
\r
LOGJSONObject j2 = new LOGJSONObject();
\r
for (String key : fields) {
\r
// filter out unwanted fields
\r
LOGJSONObject j2 = new LOGJSONObject();
\r
for (String key : fields) {
\r
- Object v = jo.opt(key);
\r
- if (v != null)
\r
- j2.put(key, v);
\r
+ Object val = jo.opt(key);
\r
+ if (val != null) {
\r
+ j2.put(key, val);
\r
+ }
\r
}
\r
jo = j2;
\r
}
\r
}
\r
jo = j2;
\r
}
\r
- String
t
= firstrow ? "\n" : ",\n";
\r
-
t
+= jo.toString();
\r
- out.print(
t
);
\r
+ String
str
= firstrow ? "\n" : ",\n";
\r
+
str
+= jo.toString();
\r
+ out.print(
str
);
\r
firstrow = false;
\r
} catch (Exception exception) {
\r
intlogger.info("Failed to handle row. Exception = " + exception.getMessage(),exception);
\r
}
\r
}
\r
firstrow = false;
\r
} catch (Exception exception) {
\r
intlogger.info("Failed to handle row. Exception = " + exception.getMessage(),exception);
\r
}
\r
}
\r
+
\r
public abstract LOGJSONable buildJSONable(ResultSet rs) throws SQLException;
\r
}
\r
public abstract LOGJSONable buildJSONable(ResultSet rs) throws SQLException;
\r
}
\r
+
\r
public class PublishRecordRowHandler extends RowHandler {
\r
public class PublishRecordRowHandler extends RowHandler {
\r
- public PublishRecordRowHandler(ServletOutputStream out, String fields, boolean b) {
\r
- super(out, fields, b);
\r
+ public PublishRecordRowHandler(ServletOutputStream out, String fields, boolean b
ool
) {
\r
+ super(out, fields, b
ool
);
\r
}
\r
}
\r
+
\r
@Override
\r
public LOGJSONable buildJSONable(ResultSet rs) throws SQLException {
\r
return new PublishRecord(rs);
\r
}
\r
}
\r
@Override
\r
public LOGJSONable buildJSONable(ResultSet rs) throws SQLException {
\r
return new PublishRecord(rs);
\r
}
\r
}
\r
+
\r
public class DeliveryRecordRowHandler extends RowHandler {
\r
public class DeliveryRecordRowHandler extends RowHandler {
\r
- public DeliveryRecordRowHandler(ServletOutputStream out, String fields, boolean b) {
\r
- super(out, fields, b);
\r
+ public DeliveryRecordRowHandler(ServletOutputStream out, String fields, boolean b
ool
) {
\r
+ super(out, fields, b
ool
);
\r
}
\r
}
\r
+
\r
@Override
\r
public LOGJSONable buildJSONable(ResultSet rs) throws SQLException {
\r
return new DeliveryRecord(rs);
\r
}
\r
}
\r
@Override
\r
public LOGJSONable buildJSONable(ResultSet rs) throws SQLException {
\r
return new DeliveryRecord(rs);
\r
}
\r
}
\r
+
\r
public class ExpiryRecordRowHandler extends RowHandler {
\r
public class ExpiryRecordRowHandler extends RowHandler {
\r
- public ExpiryRecordRowHandler(ServletOutputStream out, String fields, boolean b) {
\r
- super(out, fields, b);
\r
+ public ExpiryRecordRowHandler(ServletOutputStream out, String fields, boolean b
ool
) {
\r
+ super(out, fields, b
ool
);
\r
}
\r
}
\r
+
\r
@Override
\r
public LOGJSONable buildJSONable(ResultSet rs) throws SQLException {
\r
return new ExpiryRecord(rs);
\r
@Override
\r
public LOGJSONable buildJSONable(ResultSet rs) throws SQLException {
\r
return new ExpiryRecord(rs);
\r
@@
-156,7
+178,8
@@
public class LogServlet extends BaseServlet {
setIpFqdnRequestIDandInvocationIDForEelf("doDelete", req);
\r
eelfLogger.info(EelfMsgs.ENTRY);
\r
try {
\r
setIpFqdnRequestIDandInvocationIDForEelf("doDelete", req);
\r
eelfLogger.info(EelfMsgs.ENTRY);
\r
try {
\r
- eelfLogger.info(EelfMsgs.MESSAGE_WITH_BEHALF_AND_FEEDID, req.getHeader(BEHALF_HEADER), getIdFromPath(req) + "");
\r
+ eelfLogger.info(EelfMsgs.MESSAGE_WITH_BEHALF_AND_FEEDID,
\r
+ req.getHeader(BEHALF_HEADER), getIdFromPath(req) + "");
\r
String message = "DELETE not allowed for the logURL.";
\r
EventLogRecord elr = new EventLogRecord(req);
\r
elr.setMessage(message);
\r
String message = "DELETE not allowed for the logURL.";
\r
EventLogRecord elr = new EventLogRecord(req);
\r
elr.setMessage(message);
\r
@@
-167,6
+190,7
@@
public class LogServlet extends BaseServlet {
eelfLogger.info(EelfMsgs.EXIT);
\r
}
\r
}
\r
eelfLogger.info(EelfMsgs.EXIT);
\r
}
\r
}
\r
+
\r
/**
\r
* GET a logging URL -- retrieve logging data for a feed or subscription.
\r
* See the <b>Logging API</b> document for details on how this method should be invoked.
\r
/**
\r
* GET a logging URL -- retrieve logging data for a feed or subscription.
\r
* See the <b>Logging API</b> document for details on how this method should be invoked.
\r
@@
-176,15
+200,18
@@
public class LogServlet extends BaseServlet {
setIpFqdnRequestIDandInvocationIDForEelf("doGet", req);
\r
eelfLogger.info(EelfMsgs.ENTRY);
\r
try {
\r
setIpFqdnRequestIDandInvocationIDForEelf("doGet", req);
\r
eelfLogger.info(EelfMsgs.ENTRY);
\r
try {
\r
- eelfLogger.info(EelfMsgs.MESSAGE_WITH_BEHALF_AND_FEEDID, req.getHeader(BEHALF_HEADER), getIdFromPath(req) + "");
\r
+ eelfLogger.info(EelfMsgs.MESSAGE_WITH_BEHALF_AND_FEEDID,
\r
+ req.getHeader(BEHALF_HEADER), getIdFromPath(req) + "");
\r
int id = getIdFromPath(req);
\r
if (id < 0) {
\r
int id = getIdFromPath(req);
\r
if (id < 0) {
\r
- sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, "Missing or bad feed/subscription number.", eventlogger);
\r
+ sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST,
\r
+ "Missing or bad feed/subscription number.", eventlogger);
\r
return;
\r
}
\r
Map<String, String> map = buildMapFromRequest(req);
\r
if (map.get("err") != null) {
\r
return;
\r
}
\r
Map<String, String> map = buildMapFromRequest(req);
\r
if (map.get("err") != null) {
\r
- sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST, "Invalid arguments: " + map.get("err"), eventlogger);
\r
+ sendResponseError(resp, HttpServletResponse.SC_BAD_REQUEST,
\r
+ "Invalid arguments: " + map.get("err"), eventlogger);
\r
return;
\r
}
\r
// check Accept: header??
\r
return;
\r
}
\r
// check Accept: header??
\r
@@
-238,6
+265,7
@@
public class LogServlet extends BaseServlet {
eelfLogger.info(EelfMsgs.EXIT);
\r
}
\r
}
\r
eelfLogger.info(EelfMsgs.EXIT);
\r
}
\r
}
\r
+
\r
/**
\r
* PUT a logging URL -- not supported.
\r
*/
\r
/**
\r
* PUT a logging URL -- not supported.
\r
*/
\r
@@
-246,7
+274,8
@@
public class LogServlet extends BaseServlet {
setIpFqdnRequestIDandInvocationIDForEelf("doPut", req);
\r
eelfLogger.info(EelfMsgs.ENTRY);
\r
try {
\r
setIpFqdnRequestIDandInvocationIDForEelf("doPut", req);
\r
eelfLogger.info(EelfMsgs.ENTRY);
\r
try {
\r
- eelfLogger.info(EelfMsgs.MESSAGE_WITH_BEHALF_AND_FEEDID, req.getHeader(BEHALF_HEADER),getIdFromPath(req)+"");
\r
+ eelfLogger.info(EelfMsgs.MESSAGE_WITH_BEHALF_AND_FEEDID,
\r
+ req.getHeader(BEHALF_HEADER),getIdFromPath(req) + "");
\r
String message = "PUT not allowed for the logURL.";
\r
EventLogRecord elr = new EventLogRecord(req);
\r
elr.setMessage(message);
\r
String message = "PUT not allowed for the logURL.";
\r
EventLogRecord elr = new EventLogRecord(req);
\r
elr.setMessage(message);
\r
@@
-257,6
+286,7
@@
public class LogServlet extends BaseServlet {
eelfLogger.info(EelfMsgs.EXIT);
\r
}
\r
}
\r
eelfLogger.info(EelfMsgs.EXIT);
\r
}
\r
}
\r
+
\r
/**
\r
* POST a logging URL -- not supported.
\r
*/
\r
/**
\r
* POST a logging URL -- not supported.
\r
*/
\r
@@
-279,10
+309,10
@@
public class LogServlet extends BaseServlet {
\r
private Map<String, String> buildMapFromRequest(HttpServletRequest req) {
\r
Map<String, String> map = new HashMap<>();
\r
\r
private Map<String, String> buildMapFromRequest(HttpServletRequest req) {
\r
Map<String, String> map = new HashMap<>();
\r
- String s = req.getParameter("type");
\r
- if (s != null) {
\r
- if ("pub".equals(s
) || "del".equals(s) || "exp".equals(s
)) {
\r
- map.put("type", s);
\r
+ String s
tr
= req.getParameter("type");
\r
+ if (s
tr
!= null) {
\r
+ if ("pub".equals(s
tr) || "del".equals(str) || "exp".equals(str
)) {
\r
+ map.put("type", s
tr
);
\r
} else {
\r
map.put("err", "bad type");
\r
return map;
\r
} else {
\r
map.put("err", "bad type");
\r
return map;
\r
@@
-296,24
+326,24
@@
public class LogServlet extends BaseServlet {
map.put(REASON_SQL, "");
\r
map.put(FILENAMESQL, "");
\r
\r
map.put(REASON_SQL, "");
\r
map.put(FILENAMESQL, "");
\r
\r
- s = req.getParameter("publishId");
\r
- if (s != null) {
\r
- if (s.indexOf("'") >= 0) {
\r
+ s
tr
= req.getParameter("publishId");
\r
+ if (s
tr
!= null) {
\r
+ if (s
tr
.indexOf("'") >= 0) {
\r
map.put("err", "bad publishId");
\r
return map;
\r
}
\r
map.put("err", "bad publishId");
\r
return map;
\r
}
\r
- map.put(PUBLISHSQL, " AND PUBLISH_ID = '"
+s+
"'");
\r
+ map.put(PUBLISHSQL, " AND PUBLISH_ID = '"
+ str +
"'");
\r
}
\r
\r
}
\r
\r
- s = req.getParameter("filename");
\r
- if (s != null) {
\r
- map.put(FILENAMESQL, " AND FILENAME = '" + s + "'");
\r
+ s
tr
= req.getParameter("filename");
\r
+ if (s
tr
!= null) {
\r
+ map.put(FILENAMESQL, " AND FILENAME = '" + s
tr
+ "'");
\r
}
\r
\r
}
\r
\r
- s = req.getParameter("statusCode");
\r
- if (s != null) {
\r
+ s
tr
= req.getParameter("statusCode");
\r
+ if (s
tr
!= null) {
\r
String sql = null;
\r
String sql = null;
\r
- switch (s) {
\r
+ switch (s
tr
) {
\r
case "success":
\r
sql = " AND STATUS >= 200 AND STATUS < 300";
\r
break;
\r
case "success":
\r
sql = " AND STATUS >= 200 AND STATUS < 300";
\r
break;
\r
@@
-325,9
+355,9
@@
public class LogServlet extends BaseServlet {
break;
\r
default:
\r
try {
\r
break;
\r
default:
\r
try {
\r
- int
n = Integer.parseInt(s
);
\r
- if ((
n >= 100 && n < 600) || (n
== -1)) {
\r
- sql = " AND STATUS = " +
n
;
\r
+ int
statusCode = Integer.parseInt(str
);
\r
+ if ((
statusCode >= 100 && statusCode < 600) || (statusCode
== -1)) {
\r
+ sql = " AND STATUS = " +
statusCode
;
\r
}
\r
} catch (NumberFormatException e) {
\r
intlogger.error("Failed to parse input", e);
\r
}
\r
} catch (NumberFormatException e) {
\r
intlogger.error("Failed to parse input", e);
\r
@@
-342,16
+372,16
@@
public class LogServlet extends BaseServlet {
map.put(RESULTSQL, sql.replaceAll("STATUS", "RESULT"));
\r
}
\r
\r
map.put(RESULTSQL, sql.replaceAll("STATUS", "RESULT"));
\r
}
\r
\r
- s = req.getParameter("expiryReason");
\r
- if (s != null) {
\r
+ s
tr
= req.getParameter("expiryReason");
\r
+ if (s
tr
!= null) {
\r
map.put("type", "exp");
\r
map.put("type", "exp");
\r
- if ("notRetryable".equals(s)) {
\r
+ if ("notRetryable".equals(s
tr
)) {
\r
map.put(REASON_SQL, " AND REASON = 'notRetryable'");
\r
map.put(REASON_SQL, " AND REASON = 'notRetryable'");
\r
- } else if ("retriesExhausted".equals(s)) {
\r
+ } else if ("retriesExhausted".equals(s
tr
)) {
\r
map.put(REASON_SQL, " AND REASON = 'retriesExhausted'");
\r
map.put(REASON_SQL, " AND REASON = 'retriesExhausted'");
\r
- } else if ("diskFull".equals(s)) {
\r
+ } else if ("diskFull".equals(s
tr
)) {
\r
map.put(REASON_SQL, " AND REASON = 'diskFull'");
\r
map.put(REASON_SQL, " AND REASON = 'diskFull'");
\r
- } else if ("other".equals(s)) {
\r
+ } else if ("other".equals(s
tr
)) {
\r
map.put(REASON_SQL, " AND REASON = 'other'");
\r
} else {
\r
map.put("err", "bad expiryReason");
\r
map.put(REASON_SQL, " AND REASON = 'other'");
\r
} else {
\r
map.put("err", "bad expiryReason");
\r
@@
-380,25
+410,27
@@
public class LogServlet extends BaseServlet {
map.put(TIMESQL, String.format(" AND EVENT_TIME >= %d AND EVENT_TIME <= %d", stime, etime));
\r
return map;
\r
}
\r
map.put(TIMESQL, String.format(" AND EVENT_TIME >= %d AND EVENT_TIME <= %d", stime, etime));
\r
return map;
\r
}
\r
- private long getTimeFromParam(final String s) {
\r
- if (s == null)
\r
+
\r
+ private long getTimeFromParam(final String str) {
\r
+ if (str == null) {
\r
return 0;
\r
return 0;
\r
+ }
\r
try {
\r
// First, look for an RFC 3339 date
\r
try {
\r
// First, look for an RFC 3339 date
\r
- String fmt = (s.indexOf('.') > 0) ? FMT_2 : FMT_1;
\r
+ String fmt = (s
tr
.indexOf('.') > 0) ? FMT_2 : FMT_1;
\r
SimpleDateFormat sdf = new SimpleDateFormat(fmt);
\r
SimpleDateFormat sdf = new SimpleDateFormat(fmt);
\r
- Date d
= sdf.parse(s
);
\r
- return d.getTime();
\r
+ Date d
ate = sdf.parse(str
);
\r
+ return d
ate
.getTime();
\r
} catch (ParseException parseException) {
\r
intlogger.error("Exception in getting Time :- " + parseException.getMessage(),parseException);
\r
}
\r
try {
\r
// Also allow a long (in ms); useful for testing
\r
} catch (ParseException parseException) {
\r
intlogger.error("Exception in getting Time :- " + parseException.getMessage(),parseException);
\r
}
\r
try {
\r
// Also allow a long (in ms); useful for testing
\r
- return Long.parseLong(s);
\r
+ return Long.parseLong(s
tr
);
\r
} catch (NumberFormatException numberFormatException) {
\r
intlogger.error("Exception in getting Time :- " + numberFormatException.getMessage(),numberFormatException);
\r
}
\r
} catch (NumberFormatException numberFormatException) {
\r
intlogger.error("Exception in getting Time :- " + numberFormatException.getMessage(),numberFormatException);
\r
}
\r
- intlogger.info("Error parsing time=" + s);
\r
+ intlogger.info("Error parsing time=" + s
tr
);
\r
return -1;
\r
}
\r
\r
return -1;
\r
}
\r
\r
@@
-411,6
+443,7
@@
public class LogServlet extends BaseServlet {
getRecordsForSQL(sql, rh);
\r
}
\r
}
\r
getRecordsForSQL(sql, rh);
\r
}
\r
}
\r
+
\r
private void getDeliveryRecordsForFeed(int feedid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "del".equals(type)) {
\r
private void getDeliveryRecordsForFeed(int feedid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "del".equals(type)) {
\r
@@
-420,6
+453,7
@@
public class LogServlet extends BaseServlet {
getRecordsForSQL(sql, rh);
\r
}
\r
}
\r
getRecordsForSQL(sql, rh);
\r
}
\r
}
\r
+
\r
private void getDeliveryRecordsForSubscription(int subid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "del".equals(type)) {
\r
private void getDeliveryRecordsForSubscription(int subid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "del".equals(type)) {
\r
@@
-429,6
+463,7
@@
public class LogServlet extends BaseServlet {
getRecordsForSQL(sql, rh);
\r
}
\r
}
\r
getRecordsForSQL(sql, rh);
\r
}
\r
}
\r
+
\r
private void getExpiryRecordsForFeed(int feedid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "exp".equals(type)) {
\r
private void getExpiryRecordsForFeed(int feedid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "exp".equals(type)) {
\r
@@
-441,6
+476,7
@@
public class LogServlet extends BaseServlet {
}
\r
}
\r
}
\r
}
\r
}
\r
}
\r
+
\r
private void getExpiryRecordsForSubscription(int subid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "exp".equals(type)) {
\r
private void getExpiryRecordsForSubscription(int subid, RowHandler rh, Map<String, String> map) {
\r
String type = map.get("type");
\r
if ("all".equals(type) || "exp".equals(type)) {
\r
@@
-471,8
+507,9
@@
public class LogServlet extends BaseServlet {
} catch (SQLException sqlException) {
\r
intlogger.info("Failed to get Records. Exception = " + sqlException.getMessage(),sqlException);
\r
} finally {
\r
} catch (SQLException sqlException) {
\r
intlogger.info("Failed to get Records. Exception = " + sqlException.getMessage(),sqlException);
\r
} finally {
\r
- if (conn != null)
\r
+ if (conn != null)
{
\r
db.release(conn);
\r
db.release(conn);
\r
+ }
\r
}
\r
intlogger.debug("Time: " + (System.currentTimeMillis() - start) + " ms");
\r
}
\r
}
\r
intlogger.debug("Time: " + (System.currentTimeMillis() - start) + " ms");
\r
}
\r