Code Review
/
policy
/
engine.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "Addressing Technical Debt for ONAP-XACML"
[policy/engine.git]
/
POLICY-SDK-APP
/
src
/
main
/
java
/
org
/
onap
/
policy
/
model
/
PDPPolicyContainer.java
diff --git
a/POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPPolicyContainer.java
b/POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPPolicyContainer.java
index
a3e3e28
..
e73adf8
100644
(file)
--- a/
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPPolicyContainer.java
+++ b/
POLICY-SDK-APP/src/main/java/org/onap/policy/model/PDPPolicyContainer.java
@@
-151,7
+151,7
@@
public class PDPPolicyContainer extends PolicyItemSetChangeNotifier implements P
if (this.policies.isEmpty()) {
return false;
}
if (this.policies.isEmpty()) {
return false;
}
- return
(itemId.equals(this.policies.get(0)
));
+ return
itemId.equals(this.policies.get(0
));
}
@Override
}
@Override
@@
-162,12
+162,11
@@
public class PDPPolicyContainer extends PolicyItemSetChangeNotifier implements P
if (this.policies.isEmpty()) {
return false;
}
if (this.policies.isEmpty()) {
return false;
}
- return
(itemId.equals(this.policies.get(this.policies.size() - 1)
));
+ return
itemId.equals(this.policies.get(this.policies.size() - 1
));
}
@Override
}
@Override
- public Object addItemAfter(Object previousItemId)
- throws UnsupportedOperationException {
+ public Object addItemAfter(Object previousItemId) {
return null;
}
return null;
}
@@
-221,13
+220,12
@@
public class PDPPolicyContainer extends PolicyItemSetChangeNotifier implements P
}
@Override
}
@Override
- public Object addItem()
throws UnsupportedOperationException
{
+ public Object addItem() {
throw new UnsupportedOperationException("Cannot add an empty policy.");
}
@Override
throw new UnsupportedOperationException("Cannot add an empty policy.");
}
@Override
- public boolean removeItem(Object itemId)
- throws UnsupportedOperationException {
+ public boolean removeItem(Object itemId) {
if (LOGGER.isTraceEnabled()) {
LOGGER.trace("removeItem: " + itemId);
}
if (LOGGER.isTraceEnabled()) {
LOGGER.trace("removeItem: " + itemId);
}
@@
-249,18
+247,17
@@
public class PDPPolicyContainer extends PolicyItemSetChangeNotifier implements P
@Override
public boolean addContainerProperty(Object propertyId, Class<?> type,
@Override
public boolean addContainerProperty(Object propertyId, Class<?> type,
- Object defaultValue)
throws UnsupportedOperationException
{
+ Object defaultValue) {
return false;
}
@Override
return false;
}
@Override
- public boolean removeContainerProperty(Object propertyId)
- throws UnsupportedOperationException {
+ public boolean removeContainerProperty(Object propertyId) {
return false;
}
@Override
return false;
}
@Override
- public boolean removeAllItems()
throws UnsupportedOperationException
{
+ public boolean removeAllItems() {
return false;
}
return false;
}
@@
-292,7
+289,7
@@
public class PDPPolicyContainer extends PolicyItemSetChangeNotifier implements P
}
@Override
}
@Override
- public Object addItemAt(int index)
throws UnsupportedOperationException
{
+ public Object addItemAt(int index) {
if (LOGGER.isTraceEnabled()) {
LOGGER.trace("addItemAt: " + index);
}
if (LOGGER.isTraceEnabled()) {
LOGGER.trace("addItemAt: " + index);
}