Code Review
/
policy
/
engine.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "Addressing Technical Debt for ONAP-XACML"
[policy/engine.git]
/
ONAP-XACML
/
src
/
main
/
java
/
org
/
onap
/
policy
/
xacml
/
std
/
pap
/
StdPDPStatus.java
diff --git
a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPStatus.java
b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPStatus.java
index
5349f83
..
6e1f2d6
100644
(file)
--- a/
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPStatus.java
+++ b/
ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPStatus.java
@@
-49,6
+49,9
@@
public class StdPDPStatus implements Serializable, PDPStatus {
private transient Set<PDPPIPConfig> failedPIPConfigs = new HashSet<>();
public StdPDPStatus() {
private transient Set<PDPPIPConfig> failedPIPConfigs = new HashSet<>();
public StdPDPStatus() {
+ //
+ // Default constructor
+ //
}
public void set(StdPDPStatus newStatus) {
}
public void set(StdPDPStatus newStatus) {
@@
-151,7
+154,7
@@
public class StdPDPStatus implements Serializable, PDPStatus {
@Override
public boolean policiesOK() {
@Override
public boolean policiesOK() {
- if (
this.failedPolicies.size() > 0
) {
+ if (
!this.failedPolicies.isEmpty()
) {
return false;
}
return true;
return false;
}
return true;
@@
-185,7
+188,7
@@
public class StdPDPStatus implements Serializable, PDPStatus {
@Override
public boolean pipConfigOK() {
@Override
public boolean pipConfigOK() {
- if (
this.failedPIPConfigs.size() > 0
) {
+ if (
!this.failedPIPConfigs.isEmpty()
) {
return false;
}
return true;
return false;
}
return true;
@@
-194,13
+197,13
@@
public class StdPDPStatus implements Serializable, PDPStatus {
@Override
@JsonIgnore
public boolean isOk() {
@Override
@JsonIgnore
public boolean isOk() {
- if (
this.policiesOK() == false
) {
+ if (
!this.policiesOK()
) {
return false;
}
return false;
}
- if (
this.pipConfigOK() == false
) {
+ if (
!this.pipConfigOK()
) {
return false;
}
return false;
}
- return
(this.status == Status.UP_TO_DATE)
;
+ return
this.status == Status.UP_TO_DATE
;
}
@Override
}
@Override