gerrit.onap Code Review - ccsdk/oran.git/blob

   1 /*-
   2  * ========================LICENSE_START=================================
   3  * ONAP : ccsdk oran
   4  * ======================================================================
   5  * Copyright (C) 2019-2020 Nordix Foundation. All rights reserved.
   6  * ======================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ========================LICENSE_END===================================
  19  */
  20
  21 package org.onap.ccsdk.oran.a1policymanagementservice.tasks;
  22
  23 import static ch.qos.logback.classic.Level.ERROR;
  24 import static ch.qos.logback.classic.Level.WARN;
  25 import static org.assertj.core.api.Assertions.assertThat;
  26 import static org.awaitility.Awaitility.await;
  27 import static org.mockito.ArgumentMatchers.any;
  28 import static org.mockito.Mockito.doReturn;
  29 import static org.mockito.Mockito.spy;
  30 import static org.mockito.Mockito.times;
  31 import static org.mockito.Mockito.verify;
  32 import static org.mockito.Mockito.when;
  33
  34 import ch.qos.logback.classic.spi.ILoggingEvent;
  35 import ch.qos.logback.core.read.ListAppender;
  36
  37 import com.google.common.base.Charsets;
  38 import com.google.common.io.Resources;
  39 import com.google.gson.JsonObject;
  40 import com.google.gson.JsonParser;
  41
  42 import java.io.IOException;
  43 import java.net.URL;
  44 import java.time.Duration;
  45 import java.time.Instant;
  46 import java.util.Arrays;
  47 import java.util.Collections;
  48 import java.util.HashMap;
  49 import java.util.Optional;
  50 import java.util.Properties;
  51 import java.util.Vector;
  52
  53 import org.junit.jupiter.api.Test;
  54 import org.junit.jupiter.api.extension.ExtendWith;
  55 import org.mockito.Mock;
  56 import org.mockito.Spy;
  57 import org.mockito.junit.jupiter.MockitoExtension;
  58 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1ClientFactory;
  59 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig;
  60 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig.RicConfigUpdate.Type;
  61 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfigParser;
  62 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfigParser.ConfigParserResult;
  63 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ConfigurationFile;
  64 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ImmutableConfigParserResult;
  65 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ImmutableRicConfig;
  66 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.RicConfig;
  67 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policies;
  68 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policy;
  69 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyType;
  70 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyTypes;
  71 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric;
  72 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Rics;
  73 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Services;
  74 import org.onap.ccsdk.oran.a1policymanagementservice.utils.LoggingUtils;
  75 import org.onap.dcaegen2.services.sdk.rest.services.cbs.client.api.CbsClient;
  76 import org.onap.dcaegen2.services.sdk.rest.services.cbs.client.model.EnvProperties;
  77 import org.onap.dcaegen2.services.sdk.rest.services.cbs.client.model.ImmutableEnvProperties;
  78
  79 import reactor.core.publisher.Mono;
  80 import reactor.test.StepVerifier;
  81
  82 @ExtendWith(MockitoExtension.class)
  83 class RefreshConfigTaskTest {
  84
  85     private static final boolean CONFIG_FILE_EXISTS = true;
  86     private static final boolean CONFIG_FILE_DOES_NOT_EXIST = false;
  87
  88     private RefreshConfigTask refreshTaskUnderTest;
  89
  90     @Spy
  91     ApplicationConfig appConfig;
  92
  93     @Mock
  94     CbsClient cbsClient;
  95
  96     @Mock
  97     ConfigurationFile configurationFileMock;
  98
  99     private static final String RIC_1_NAME = "ric1";
 100     private static final RicConfig CORRECT_RIC_CONIFG = ImmutableRicConfig.builder() //
 101             .ricId(RIC_1_NAME) //
 102             .baseUrl("http://localhost:8080/") //
 103             .managedElementIds(new Vector<String>(Arrays.asList("kista_1", "kista_2"))) //
 104             .controllerName("") //
 105             .build();
 106
 107     private static EnvProperties properties() {
 108         return ImmutableEnvProperties.builder() //
 109                 .consulHost("host") //
 110                 .consulPort(123) //
 111                 .cbsName("cbsName") //
 112                 .appName("appName") //
 113                 .build();
 114     }
 115
 116     private RefreshConfigTask createTestObject(boolean configFileExists) {
 117         return createTestObject(configFileExists, new Rics(), new Policies(appConfig), true);
 118     }
 119
 120     private RefreshConfigTask createTestObject(boolean configFileExists, Rics rics, Policies policies,
 121             boolean stubConfigFileExists) {
 122
 123         RefreshConfigTask obj = spy(new RefreshConfigTask(configurationFileMock, appConfig, rics, policies,
 124                 new Services(appConfig), new PolicyTypes(appConfig), new A1ClientFactory(appConfig)));
 125         if (stubConfigFileExists) {
 126             when(configurationFileMock.readFile()).thenReturn(Optional.empty());
 127             doReturn(123L).when(configurationFileMock).getLastModified();
 128         }
 129         return obj;
 130     }
 131
 132     @Test
 133     void whenTheConfigurationFits_thenConfiguredRicsArePutInRepository() throws Exception {
 134         refreshTaskUnderTest = this.createTestObject(CONFIG_FILE_EXISTS);
 135         refreshTaskUnderTest.systemEnvironment = new Properties();
 136         // When
 137         when(configurationFileMock.readFile()).thenReturn(getCorrectJson());
 138
 139         StepVerifier //
 140                 .create(refreshTaskUnderTest.createRefreshTask()) //
 141                 .expectSubscription() //
 142                 .expectNext(Type.ADDED) //
 143                 .expectNext(Type.ADDED) //
 144                 .thenCancel() //
 145                 .verify();
 146
 147         // Then
 148         verify(refreshTaskUnderTest).loadConfigurationFromFile();
 149
 150         verify(refreshTaskUnderTest, times(2)).addRic(any(Ric.class));
 151
 152         Iterable<RicConfig> ricConfigs = appConfig.getRicConfigs();
 153         RicConfig ricConfig = ricConfigs.iterator().next();
 154         assertThat(ricConfigs).isNotNull();
 155         assertThat(ricConfig).isEqualTo(CORRECT_RIC_CONIFG);
 156     }
 157
 158     @Test
 159     void whenFileExistsButJsonIsIncorrect_thenNoRicsArePutInRepository() throws Exception {
 160         refreshTaskUnderTest = this.createTestObject(CONFIG_FILE_EXISTS);
 161
 162         // When
 163         when(configurationFileMock.readFile()).thenReturn(Optional.empty());
 164
 165         StepVerifier //
 166                 .create(refreshTaskUnderTest.createRefreshTask()) //
 167                 .expectSubscription() //
 168                 .expectNoEvent(Duration.ofMillis(100)) //
 169                 .thenCancel() //
 170                 .verify();
 171
 172         // Then
 173         verify(refreshTaskUnderTest).loadConfigurationFromFile();
 174         assertThat(appConfig.getRicConfigs()).isEmpty();
 175     }
 176
 177     @Test
 178     void whenPeriodicConfigRefreshNoConsul_thenErrorIsLogged() {
 179         refreshTaskUnderTest = this.createTestObject(CONFIG_FILE_DOES_NOT_EXIST);
 180         refreshTaskUnderTest.systemEnvironment = new Properties();
 181
 182         EnvProperties props = properties();
 183         doReturn(Mono.just(props)).when(refreshTaskUnderTest).getEnvironment(any());
 184
 185         doReturn(Mono.just(cbsClient)).when(refreshTaskUnderTest).createCbsClient(props);
 186         when(cbsClient.get(any())).thenReturn(Mono.error(new IOException()));
 187
 188         final ListAppender<ILoggingEvent> logAppender = LoggingUtils.getLogListAppender(RefreshConfigTask.class, WARN);
 189
 190         StepVerifier //
 191                 .create(refreshTaskUnderTest.createRefreshTask()) //
 192                 .expectSubscription() //
 193                 .expectNoEvent(Duration.ofMillis(1000)) //
 194                 .thenCancel() //
 195                 .verify();
 196
 197         await().until(() -> logAppender.list.size() > 0);
 198         assertThat(logAppender.list.get(0).getFormattedMessage())
 199                 .isEqualTo("Could not refresh application configuration. java.io.IOException");
 200     }
 201
 202     @Test
 203     void whenPeriodicConfigRefreshSuccess_thenNewConfigIsCreatedAndRepositoryUpdated() throws Exception {
 204         Rics rics = new Rics();
 205         Policies policies = new Policies(appConfig);
 206         refreshTaskUnderTest = this.createTestObject(CONFIG_FILE_DOES_NOT_EXIST, rics, policies, false);
 207         refreshTaskUnderTest.systemEnvironment = new Properties();
 208
 209         RicConfig changedRicConfig = getRicConfig(RIC_1_NAME);
 210         rics.put(new Ric(changedRicConfig));
 211         RicConfig removedRicConfig = getRicConfig("removed");
 212         Ric removedRic = new Ric(removedRicConfig);
 213         rics.put(removedRic);
 214         appConfig.setConfiguration(configParserResult(changedRicConfig, removedRicConfig));
 215
 216         Policy policy = getPolicy(removedRic);
 217         policies.put(policy);
 218
 219         EnvProperties props = properties();
 220         doReturn(Mono.just(props)).when(refreshTaskUnderTest).getEnvironment(any());
 221         doReturn(Mono.just(cbsClient)).when(refreshTaskUnderTest).createCbsClient(props);
 222
 223         JsonObject configAsJson = getCorrectJson().get();
 224         String newBaseUrl = "newBaseUrl";
 225         modifyTheRicConfiguration(configAsJson, newBaseUrl);
 226         when(cbsClient.get(any())).thenReturn(Mono.just(configAsJson));
 227
 228         StepVerifier //
 229                 .create(refreshTaskUnderTest.createRefreshTask()) //
 230                 .expectSubscription() //
 231                 .expectNextCount(3) // CHANGED REMOVED ADDED
 232                 .thenCancel() //
 233                 .verify();
 234
 235         assertThat(appConfig.getRicConfigs()).hasSize(2);
 236         assertThat(appConfig.getRic(RIC_1_NAME).baseUrl()).isEqualTo(newBaseUrl);
 237         String ric2Name = "ric2";
 238         assertThat(appConfig.getRic(ric2Name)).isNotNull();
 239
 240         // assertThat(rics.size()).isEqualTo(2);
 241         assertThat(rics.get(RIC_1_NAME).getConfig().baseUrl()).isEqualTo(newBaseUrl);
 242         assertThat(rics.get(ric2Name)).isNotNull();
 243
 244         assertThat(policies.size()).isZero();
 245     }
 246
 247     @Test
 248     void whenPeriodicConfigRefreshInvalidJson_thenErrorIsLogged() throws Exception {
 249         Rics rics = new Rics();
 250         Policies policies = new Policies(appConfig);
 251         refreshTaskUnderTest = this.createTestObject(CONFIG_FILE_DOES_NOT_EXIST, rics, policies, false);
 252         refreshTaskUnderTest.systemEnvironment = new Properties();
 253
 254         appConfig.setConfiguration(configParserResult());
 255
 256         EnvProperties props = properties();
 257         doReturn(Mono.just(props)).when(refreshTaskUnderTest).getEnvironment(any());
 258         doReturn(Mono.just(cbsClient)).when(refreshTaskUnderTest).createCbsClient(props);
 259
 260         JsonObject emptyJsonObject = new JsonObject();
 261         when(cbsClient.get(any())).thenReturn(Mono.just(emptyJsonObject));
 262
 263         final ListAppender<ILoggingEvent> logAppender = LoggingUtils.getLogListAppender(RefreshConfigTask.class, ERROR);
 264
 265         StepVerifier //
 266                 .create(refreshTaskUnderTest.createRefreshTask()) //
 267                 .expectSubscription() //
 268                 .expectNoEvent(Duration.ofMillis(1000)) //
 269                 .thenCancel() //
 270                 .verify();
 271
 272         await().until(() -> logAppender.list.size() > 0);
 273         assertThat(logAppender.list.get(0).getFormattedMessage()).startsWith(
 274                 "Could not parse configuration org.onap.ccsdk.oran.a1policymanagementservice.exceptions.ServiceException: ");
 275     }
 276
 277     private RicConfig getRicConfig(String name) {
 278         RicConfig ricConfig = ImmutableRicConfig.builder() //
 279                 .ricId(name) //
 280                 .baseUrl("url") //
 281                 .managedElementIds(Collections.emptyList()) //
 282                 .controllerName("controllerName") //
 283                 .build();
 284         return ricConfig;
 285     }
 286
 287     private Policy getPolicy(Ric ric) {
 288         PolicyType type = PolicyType.builder() //
 289                 .id("type") //
 290                 .schema("{}") //
 291                 .build();
 292         Policy policy = Policy.builder() //
 293                 .id("id") //
 294                 .type(type) //
 295                 .lastModified(Instant.now()) //
 296                 .ric(ric) //
 297                 .json("{}") //
 298                 .ownerServiceId("ownerServiceId") //
 299                 .isTransient(false) //
 300                 .statusNotificationUri("/policy_status?id=XXX") //
 301                 .build();
 302         return policy;
 303     }
 304
 305     ConfigParserResult configParserResult(RicConfig... rics) {
 306         return ImmutableConfigParserResult.builder() //
 307                 .ricConfigs(Arrays.asList(rics)) //
 308                 .dmaapConsumerTopicUrl("") //
 309                 .dmaapProducerTopicUrl("") //
 310                 .controllerConfigs(new HashMap<>()) //
 311                 .build();
 312     }
 313
 314     private void modifyTheRicConfiguration(JsonObject configAsJson, String newBaseUrl) {
 315         ((JsonObject) configAsJson.getAsJsonObject("config") //
 316                 .getAsJsonArray("ric").get(0)) //
 317                         .addProperty("baseUrl", newBaseUrl);
 318     }
 319
 320     private static Optional<JsonObject> getCorrectJson() throws IOException {
 321         URL url = ApplicationConfigParser.class.getClassLoader().getResource("test_application_configuration.json");
 322         String string = Resources.toString(url, Charsets.UTF_8);
 323         return Optional.of(JsonParser.parseString(string).getAsJsonObject());
 324     }
 325 }