gerrit.onap Code Review - ccsdk/oran.git/blob

   1 /*-
   2  * ========================LICENSE_START=================================
   3  * ONAP : ccsdk oran
   4  * ======================================================================
   5  * Copyright (C) 2020 Nordix Foundation. All rights reserved.
   6  * ======================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ========================LICENSE_END===================================
  19  */
  20
  21 package org.onap.ccsdk.oran.a1policymanagementservice.tasks;
  22
  23 import static org.assertj.core.api.Assertions.assertThat;
  24 import static org.awaitility.Awaitility.await;
  25 import static org.mockito.ArgumentMatchers.any;
  26 import static org.mockito.Mockito.doReturn;
  27 import static org.mockito.Mockito.spy;
  28 import static org.mockito.Mockito.times;
  29 import static org.mockito.Mockito.verify;
  30 import static org.mockito.Mockito.verifyNoInteractions;
  31 import static org.mockito.Mockito.verifyNoMoreInteractions;
  32 import static org.mockito.Mockito.when;
  33
  34 import java.time.Duration;
  35 import java.time.Instant;
  36 import java.util.Arrays;
  37 import java.util.Collections;
  38
  39 import org.junit.jupiter.api.BeforeEach;
  40 import org.junit.jupiter.api.Test;
  41 import org.junit.jupiter.api.extension.ExtendWith;
  42 import org.mockito.Mock;
  43 import org.mockito.junit.jupiter.MockitoExtension;
  44 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1Client;
  45 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1ClientFactory;
  46 import org.onap.ccsdk.oran.a1policymanagementservice.clients.AsyncRestClientFactory;
  47 import org.onap.ccsdk.oran.a1policymanagementservice.clients.SecurityContext;
  48 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig;
  49 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ImmutableRicConfig;
  50 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policies;
  51 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policy;
  52 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyType;
  53 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyTypes;
  54 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric;
  55 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric.RicState;
  56 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Rics;
  57 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Service;
  58 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Services;
  59
  60 import reactor.core.publisher.Flux;
  61 import reactor.core.publisher.Mono;
  62
  63 @ExtendWith(MockitoExtension.class)
  64 class RicSynchronizationTaskTest {
  65     private static final String POLICY_TYPE_1_NAME = "type1";
  66     private static final PolicyType POLICY_TYPE_1 = PolicyType.builder() //
  67             .id(POLICY_TYPE_1_NAME) //
  68             .schema("") //
  69             .build();
  70
  71     private static final String RIC_1_NAME = "ric1";
  72
  73     private static Ric ric1;
  74
  75     private static Policy createPolicy(String policyId, boolean isTransient) {
  76         return Policy.builder() //
  77                 .id(policyId) //
  78                 .json("") //
  79                 .ownerServiceId("service") //
  80                 .ric(ric1) //
  81                 .type(POLICY_TYPE_1) //
  82                 .lastModified(Instant.now()) //
  83                 .isTransient(isTransient) //
  84                 .statusNotificationUri("statusNotificationUri") //
  85                 .build();
  86     }
  87
  88     private static Policy policy1;
  89     private static final String SERVICE_1_NAME = "service1";
  90     private static final String SERVICE_1_CALLBACK_URL = "callbackUrl";
  91     private static Service service1;
  92
  93     @Mock
  94     private A1Client a1ClientMock;
  95
  96     @Mock
  97     private A1ClientFactory a1ClientFactoryMock;
  98
  99     private PolicyTypes policyTypes;
 100     private Policies policies;
 101     private Services services;
 102     private Rics rics;
 103
 104     private final ApplicationConfig appConfig = new ApplicationConfig();
 105
 106     @BeforeEach
 107     void init() {
 108         ric1 = new Ric(ImmutableRicConfig.builder() //
 109                 .ricId(RIC_1_NAME) //
 110                 .baseUrl("baseUrl1") //
 111                 .managedElementIds(Collections.emptyList()) //
 112                 .controllerName("controllerName") //
 113                 .build());
 114         policy1 = createPolicy("policyId1", false);
 115         policyTypes = new PolicyTypes(appConfig);
 116         policies = new Policies(appConfig);
 117         services = new Services(appConfig);
 118         rics = new Rics();
 119
 120         service1 = new Service(SERVICE_1_NAME, Duration.ofSeconds(1), SERVICE_1_CALLBACK_URL);
 121     }
 122
 123     private RicSynchronizationTask createTask() {
 124         ApplicationConfig config = new ApplicationConfig();
 125         AsyncRestClientFactory restClientFactory =
 126                 new AsyncRestClientFactory(config.getWebClientConfig(), new SecurityContext(""));
 127         return new RicSynchronizationTask(a1ClientFactoryMock, policyTypes, policies, services, restClientFactory,
 128                 rics);
 129     };
 130
 131     @Test
 132     void ricAlreadySynchronizing_thenNoSynchronization() {
 133         ric1.setState(RicState.SYNCHRONIZING);
 134         ric1.addSupportedPolicyType(POLICY_TYPE_1);
 135
 136         policyTypes.put(POLICY_TYPE_1);
 137         policies.put(policy1);
 138
 139         RicSynchronizationTask synchronizerUnderTest = createTask();
 140
 141         synchronizerUnderTest.run(ric1);
 142
 143         verifyNoInteractions(a1ClientMock);
 144
 145         assertThat(policyTypes.size()).isEqualTo(1);
 146         assertThat(policies.size()).isEqualTo(1);
 147         assertThat(ric1.getState()).isEqualTo(RicState.SYNCHRONIZING);
 148         assertThat(ric1.getSupportedPolicyTypeNames()).hasSize(1);
 149     }
 150
 151     @Test
 152     void ricIdlePolicyTypeInRepo_thenSynchronizationWithReuseOfTypeFromRepoAndCorrectServiceNotified() {
 153         rics.put(ric1);
 154         ric1.setState(RicState.AVAILABLE);
 155
 156         policyTypes.put(POLICY_TYPE_1);
 157
 158         services.put(service1);
 159         Service serviceWithoutCallbackUrlShouldNotBeNotified = new Service("service2", Duration.ofSeconds(1), "");
 160         services.put(serviceWithoutCallbackUrlShouldNotBeNotified);
 161
 162         setUpCreationOfA1Client();
 163         simulateRicWithOnePolicyType();
 164
 165         RicSynchronizationTask synchronizerUnderTest = spy(createTask());
 166
 167         ric1.setState(RicState.UNAVAILABLE);
 168         synchronizerUnderTest.run(ric1);
 169         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 170
 171         verify(a1ClientMock, times(1)).getPolicyTypeIdentities();
 172         verifyNoMoreInteractions(a1ClientMock);
 173
 174         verify(synchronizerUnderTest).run(ric1);
 175
 176         assertThat(policyTypes.size()).isEqualTo(1);
 177         assertThat(policies.size()).isZero();
 178         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 179     }
 180
 181     @Test
 182     void ricIdlePolicyTypeNotInRepo_thenSynchronizationWithTypeFromRic() throws Exception {
 183         ric1.setState(RicState.AVAILABLE);
 184         rics.put(ric1);
 185
 186         setUpCreationOfA1Client();
 187         simulateRicWithOnePolicyType();
 188         String typeSchema = "schema";
 189         when(a1ClientMock.getPolicyTypeSchema(POLICY_TYPE_1_NAME)).thenReturn(Mono.just(typeSchema));
 190
 191         RicSynchronizationTask synchronizerUnderTest = createTask();
 192
 193         ric1.setState(RicState.UNAVAILABLE);
 194         synchronizerUnderTest.run(ric1);
 195         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 196
 197         verify(a1ClientMock).getPolicyTypeIdentities();
 198         verifyNoMoreInteractions(a1ClientMock);
 199
 200         assertThat(policyTypes.size()).isEqualTo(1);
 201         assertThat(policyTypes.getType(POLICY_TYPE_1_NAME).getSchema()).isEqualTo(typeSchema);
 202         assertThat(policies.size()).isZero();
 203         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 204     }
 205
 206     @Test
 207     void ricIdleAndHavePolicies_thenSynchronizationWithRecreationOfPolicies() {
 208         ric1.setState(RicState.AVAILABLE);
 209         rics.put(ric1);
 210
 211         Policy transientPolicy = createPolicy("transientPolicyId", true);
 212
 213         policies.put(transientPolicy);
 214         policies.put(policy1);
 215
 216         setUpCreationOfA1Client();
 217         simulateRicWithNoPolicyTypes();
 218
 219         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.just("OK"));
 220         when(a1ClientMock.putPolicy(any(Policy.class))).thenReturn(Mono.just("OK"));
 221
 222         RicSynchronizationTask synchronizerUnderTest = createTask();
 223
 224         ric1.setState(RicState.UNAVAILABLE);
 225         synchronizerUnderTest.run(ric1);
 226         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 227
 228         verify(a1ClientMock).deleteAllPolicies();
 229         verify(a1ClientMock).putPolicy(policy1);
 230         verifyNoMoreInteractions(a1ClientMock);
 231
 232         assertThat(policyTypes.size()).isZero();
 233         assertThat(policies.size()).isEqualTo(1); // The transient policy shall be deleted
 234         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 235     }
 236
 237     @Test
 238     void ricIdleAndErrorDeletingPoliciesFirstTime_thenSynchronizationWithDeletionOfPolicies() {
 239         ric1.setState(RicState.AVAILABLE);
 240         rics.put(ric1);
 241
 242         policies.put(policy1);
 243
 244         setUpCreationOfA1Client();
 245         simulateRicWithNoPolicyTypes();
 246
 247         when(a1ClientMock.deleteAllPolicies()) //
 248                 .thenReturn(Flux.error(new Exception("Exception"))) //
 249                 .thenReturn(Flux.just("OK"));
 250
 251         RicSynchronizationTask synchronizerUnderTest = createTask();
 252
 253         ric1.setState(RicState.UNAVAILABLE);
 254         synchronizerUnderTest.run(ric1);
 255         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 256
 257         verify(a1ClientMock, times(2)).deleteAllPolicies();
 258         verifyNoMoreInteractions(a1ClientMock);
 259
 260         assertThat(policyTypes.size()).isZero();
 261         assertThat(policies.size()).isZero();
 262         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 263     }
 264
 265     @Test
 266     void ricIdleAndErrorDeletingPoliciesAllTheTime_thenSynchronizationWithFailedRecovery() {
 267         setUpCreationOfA1Client();
 268         simulateRicWithNoPolicyTypes();
 269
 270         policies.put(policy1);
 271
 272         String originalErrorMessage = "Exception";
 273         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.error(new Exception(originalErrorMessage)));
 274
 275         RicSynchronizationTask synchronizerUnderTest = createTask();
 276
 277         ric1.setState(RicState.AVAILABLE);
 278         synchronizerUnderTest.run(ric1);
 279         await().untilAsserted(() -> RicState.UNAVAILABLE.equals(ric1.getState()));
 280
 281         verify(a1ClientMock, times(2)).deleteAllPolicies();
 282         verifyNoMoreInteractions(a1ClientMock);
 283
 284         assertThat(policyTypes.size()).isZero();
 285         assertThat(policies.size()).isZero();
 286         assertThat(ric1.getState()).isEqualTo(RicState.UNAVAILABLE);
 287     }
 288
 289     private void setUpCreationOfA1Client() {
 290         when(a1ClientFactoryMock.createA1Client(any(Ric.class))).thenReturn(Mono.just(a1ClientMock));
 291         doReturn(Flux.empty()).when(a1ClientMock).deleteAllPolicies();
 292     }
 293
 294     private void simulateRicWithOnePolicyType() {
 295         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Arrays.asList(POLICY_TYPE_1_NAME)));
 296     }
 297
 298     private void simulateRicWithNoPolicyTypes() {
 299         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Collections.emptyList()));
 300     }
 301 }