gerrit.onap Code Review - ccsdk/oran.git/blob

   1 /*-
   2  * ========================LICENSE_START=================================
   3  * ONAP : ccsdk oran
   4  * ======================================================================
   5  * Copyright (C) 2020 Nordix Foundation. All rights reserved.
   6  * ======================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ========================LICENSE_END===================================
  19  */
  20
  21 package org.onap.ccsdk.oran.a1policymanagementservice.tasks;
  22
  23 import static org.assertj.core.api.Assertions.assertThat;
  24 import static org.mockito.ArgumentMatchers.any;
  25 import static org.mockito.Mockito.doReturn;
  26 import static org.mockito.Mockito.spy;
  27 import static org.mockito.Mockito.times;
  28 import static org.mockito.Mockito.verify;
  29 import static org.mockito.Mockito.verifyNoInteractions;
  30 import static org.mockito.Mockito.verifyNoMoreInteractions;
  31 import static org.mockito.Mockito.when;
  32
  33 import java.time.Duration;
  34 import java.time.Instant;
  35 import java.util.Arrays;
  36 import java.util.Collections;
  37
  38 import org.junit.jupiter.api.BeforeEach;
  39 import org.junit.jupiter.api.Test;
  40 import org.junit.jupiter.api.extension.ExtendWith;
  41 import org.mockito.Mock;
  42 import org.mockito.junit.jupiter.MockitoExtension;
  43 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1Client;
  44 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1ClientFactory;
  45 import org.onap.ccsdk.oran.a1policymanagementservice.clients.AsyncRestClientFactory;
  46 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig;
  47 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ImmutableRicConfig;
  48 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policies;
  49 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policy;
  50 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyType;
  51 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyTypes;
  52 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric;
  53 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric.RicState;
  54 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Rics;
  55 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Service;
  56 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Services;
  57
  58 import reactor.core.publisher.Flux;
  59 import reactor.core.publisher.Mono;
  60
  61 @ExtendWith(MockitoExtension.class)
  62 class RicSynchronizationTaskTest {
  63     private static final String POLICY_TYPE_1_NAME = "type1";
  64     private static final PolicyType POLICY_TYPE_1 = PolicyType.builder() //
  65             .id(POLICY_TYPE_1_NAME) //
  66             .schema("") //
  67             .build();
  68
  69     private static final String RIC_1_NAME = "ric1";
  70     private static final Ric RIC_1 = new Ric(ImmutableRicConfig.builder() //
  71             .ricId(RIC_1_NAME) //
  72             .baseUrl("baseUrl1") //
  73             .managedElementIds(Collections.emptyList()) //
  74             .controllerName("controllerName") //
  75             .build());
  76
  77     private static Policy createPolicy(String policyId, boolean isTransient) {
  78         return Policy.builder() //
  79                 .id(policyId) //
  80                 .json("") //
  81                 .ownerServiceId("service") //
  82                 .ric(RIC_1) //
  83                 .type(POLICY_TYPE_1) //
  84                 .lastModified(Instant.now()) //
  85                 .isTransient(isTransient) //
  86                 .statusNotificationUri("statusNotificationUri") //
  87                 .build();
  88     }
  89
  90     private static final Policy POLICY_1 = createPolicy("policyId1", false);
  91
  92     private static final String SERVICE_1_NAME = "service1";
  93     private static final String SERVICE_1_CALLBACK_URL = "callbackUrl";
  94     private static final Service SERVICE_1 = new Service(SERVICE_1_NAME, Duration.ofSeconds(1), SERVICE_1_CALLBACK_URL);
  95
  96     @Mock
  97     private A1Client a1ClientMock;
  98
  99     @Mock
 100     private A1ClientFactory a1ClientFactoryMock;
 101
 102     private PolicyTypes policyTypes;
 103     private Policies policies;
 104     private Services services;
 105     private Rics rics;
 106
 107     private final ApplicationConfig appConfig = new ApplicationConfig();
 108
 109     @BeforeEach
 110     void init() {
 111         policyTypes = new PolicyTypes(appConfig);
 112         policies = new Policies(appConfig);
 113         services = new Services();
 114         rics = new Rics();
 115         RIC_1.setState(RicState.UNAVAILABLE);
 116         RIC_1.clearSupportedPolicyTypes();
 117     }
 118
 119     private RicSynchronizationTask createTask() {
 120         ApplicationConfig config = new ApplicationConfig();
 121         AsyncRestClientFactory restClientFactory = new AsyncRestClientFactory(config.getWebClientConfig());
 122         return new RicSynchronizationTask(a1ClientFactoryMock, policyTypes, policies, services, restClientFactory,
 123                 rics);
 124     };
 125
 126     @Test
 127     void ricAlreadySynchronizing_thenNoSynchronization() {
 128         RIC_1.setState(RicState.SYNCHRONIZING);
 129         RIC_1.addSupportedPolicyType(POLICY_TYPE_1);
 130
 131         policyTypes.put(POLICY_TYPE_1);
 132         policies.put(POLICY_1);
 133
 134         RicSynchronizationTask synchronizerUnderTest = createTask();
 135
 136         synchronizerUnderTest.run(RIC_1);
 137
 138         verifyNoInteractions(a1ClientMock);
 139
 140         assertThat(policyTypes.size()).isEqualTo(1);
 141         assertThat(policies.size()).isEqualTo(1);
 142         assertThat(RIC_1.getState()).isEqualTo(RicState.SYNCHRONIZING);
 143         assertThat(RIC_1.getSupportedPolicyTypeNames()).hasSize(1);
 144     }
 145
 146     @Test
 147     void ricIdlePolicyTypeInRepo_thenSynchronizationWithReuseOfTypeFromRepoAndCorrectServiceNotified() {
 148         rics.put(RIC_1);
 149         RIC_1.setState(RicState.AVAILABLE);
 150
 151         policyTypes.put(POLICY_TYPE_1);
 152
 153         services.put(SERVICE_1);
 154         Service serviceWithoutCallbackUrlShouldNotBeNotified = new Service("service2", Duration.ofSeconds(1), "");
 155         services.put(serviceWithoutCallbackUrlShouldNotBeNotified);
 156
 157         setUpCreationOfA1Client();
 158         simulateRicWithOnePolicyType();
 159
 160         RicSynchronizationTask synchronizerUnderTest = spy(createTask());
 161
 162         synchronizerUnderTest.run(RIC_1);
 163
 164         verify(a1ClientMock, times(1)).getPolicyTypeIdentities();
 165         verifyNoMoreInteractions(a1ClientMock);
 166
 167         verify(synchronizerUnderTest).run(RIC_1);
 168         verify(synchronizerUnderTest).notifyServices(any());
 169
 170         assertThat(policyTypes.size()).isEqualTo(1);
 171         assertThat(policies.size()).isZero();
 172         assertThat(RIC_1.getState()).isEqualTo(RicState.AVAILABLE);
 173     }
 174
 175     @Test
 176     void ricIdlePolicyTypeNotInRepo_thenSynchronizationWithTypeFromRic() throws Exception {
 177         RIC_1.setState(RicState.AVAILABLE);
 178         rics.put(RIC_1);
 179
 180         setUpCreationOfA1Client();
 181         simulateRicWithOnePolicyType();
 182         String typeSchema = "schema";
 183         when(a1ClientMock.getPolicyTypeSchema(POLICY_TYPE_1_NAME)).thenReturn(Mono.just(typeSchema));
 184
 185         RicSynchronizationTask synchronizerUnderTest = createTask();
 186
 187         synchronizerUnderTest.run(RIC_1);
 188
 189         verify(a1ClientMock).getPolicyTypeIdentities();
 190         verifyNoMoreInteractions(a1ClientMock);
 191
 192         assertThat(policyTypes.size()).isEqualTo(1);
 193         assertThat(policyTypes.getType(POLICY_TYPE_1_NAME).getSchema()).isEqualTo(typeSchema);
 194         assertThat(policies.size()).isZero();
 195         assertThat(RIC_1.getState()).isEqualTo(RicState.AVAILABLE);
 196     }
 197
 198     @Test
 199     void ricIdleAndHavePolicies_thenSynchronizationWithRecreationOfPolicies() {
 200         RIC_1.setState(RicState.AVAILABLE);
 201         rics.put(RIC_1);
 202
 203         Policy transientPolicy = createPolicy("transientPolicyId", true);
 204
 205         policies.put(transientPolicy);
 206         policies.put(POLICY_1);
 207
 208         setUpCreationOfA1Client();
 209         simulateRicWithNoPolicyTypes();
 210
 211         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.just("OK"));
 212         when(a1ClientMock.putPolicy(any(Policy.class))).thenReturn(Mono.just("OK"));
 213
 214         RicSynchronizationTask synchronizerUnderTest = createTask();
 215
 216         synchronizerUnderTest.run(RIC_1);
 217
 218         verify(a1ClientMock).deleteAllPolicies();
 219         verify(a1ClientMock).putPolicy(POLICY_1);
 220         verifyNoMoreInteractions(a1ClientMock);
 221
 222         assertThat(policyTypes.size()).isZero();
 223         assertThat(policies.size()).isEqualTo(1); // The transient policy shall be deleted
 224         assertThat(RIC_1.getState()).isEqualTo(RicState.AVAILABLE);
 225     }
 226
 227     @Test
 228     void ricIdleAndErrorDeletingPoliciesFirstTime_thenSynchronizationWithDeletionOfPolicies() {
 229         RIC_1.setState(RicState.AVAILABLE);
 230         rics.put(RIC_1);
 231
 232         policies.put(POLICY_1);
 233
 234         setUpCreationOfA1Client();
 235         simulateRicWithNoPolicyTypes();
 236
 237         when(a1ClientMock.deleteAllPolicies()) //
 238                 .thenReturn(Flux.error(new Exception("Exception"))) //
 239                 .thenReturn(Flux.just("OK"));
 240
 241         RicSynchronizationTask synchronizerUnderTest = createTask();
 242
 243         synchronizerUnderTest.run(RIC_1);
 244
 245         verify(a1ClientMock, times(2)).deleteAllPolicies();
 246         verifyNoMoreInteractions(a1ClientMock);
 247
 248         assertThat(policyTypes.size()).isZero();
 249         assertThat(policies.size()).isZero();
 250         assertThat(RIC_1.getState()).isEqualTo(RicState.AVAILABLE);
 251     }
 252
 253     @Test
 254     void ricIdleAndErrorDeletingPoliciesAllTheTime_thenSynchronizationWithFailedRecovery() {
 255         RIC_1.setState(RicState.AVAILABLE);
 256
 257         policies.put(POLICY_1);
 258
 259         setUpCreationOfA1Client();
 260         simulateRicWithNoPolicyTypes();
 261
 262         String originalErrorMessage = "Exception";
 263         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.error(new Exception(originalErrorMessage)));
 264
 265         RicSynchronizationTask synchronizerUnderTest = createTask();
 266
 267         synchronizerUnderTest.run(RIC_1);
 268
 269         verify(a1ClientMock, times(2)).deleteAllPolicies();
 270         verifyNoMoreInteractions(a1ClientMock);
 271
 272         assertThat(policyTypes.size()).isZero();
 273         assertThat(policies.size()).isZero();
 274         assertThat(RIC_1.getState()).isEqualTo(RicState.UNAVAILABLE);
 275     }
 276
 277     private void setUpCreationOfA1Client() {
 278         when(a1ClientFactoryMock.createA1Client(any(Ric.class))).thenReturn(Mono.just(a1ClientMock));
 279         doReturn(Flux.empty()).when(a1ClientMock).deleteAllPolicies();
 280     }
 281
 282     private void simulateRicWithOnePolicyType() {
 283         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Arrays.asList(POLICY_TYPE_1_NAME)));
 284     }
 285
 286     private void simulateRicWithNoPolicyTypes() {
 287         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Collections.emptyList()));
 288     }
 289 }