gerrit.onap Code Review - ccsdk/oran.git/blob

   1 /*-
   2  * ========================LICENSE_START=================================
   3  * ONAP : ccsdk oran
   4  * ======================================================================
   5  * Copyright (C) 2020 Nordix Foundation. All rights reserved.
   6  * ======================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ========================LICENSE_END===================================
  19  */
  20
  21 package org.onap.ccsdk.oran.a1policymanagementservice.tasks;
  22
  23 import static org.assertj.core.api.Assertions.assertThat;
  24 import static org.awaitility.Awaitility.await;
  25 import static org.mockito.ArgumentMatchers.any;
  26 import static org.mockito.Mockito.doReturn;
  27 import static org.mockito.Mockito.spy;
  28 import static org.mockito.Mockito.times;
  29 import static org.mockito.Mockito.verify;
  30 import static org.mockito.Mockito.verifyNoInteractions;
  31 import static org.mockito.Mockito.verifyNoMoreInteractions;
  32 import static org.mockito.Mockito.when;
  33
  34 import java.time.Duration;
  35 import java.time.Instant;
  36 import java.util.Arrays;
  37 import java.util.Collections;
  38
  39 import org.junit.jupiter.api.BeforeEach;
  40 import org.junit.jupiter.api.Test;
  41 import org.junit.jupiter.api.extension.ExtendWith;
  42 import org.mockito.Mock;
  43 import org.mockito.junit.jupiter.MockitoExtension;
  44 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1Client;
  45 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1ClientFactory;
  46 import org.onap.ccsdk.oran.a1policymanagementservice.clients.AsyncRestClientFactory;
  47 import org.onap.ccsdk.oran.a1policymanagementservice.clients.SecurityContext;
  48 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig;
  49 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.RicConfig;
  50 import org.onap.ccsdk.oran.a1policymanagementservice.exceptions.ServiceException;
  51 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policies;
  52 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policy;
  53 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyType;
  54 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyTypes;
  55 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric;
  56 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric.RicState;
  57 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Rics;
  58 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Service;
  59 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Services;
  60 import org.springframework.web.reactive.function.client.WebClientRequestException;
  61 import org.springframework.web.reactive.function.client.WebClientResponseException;
  62
  63 import reactor.core.publisher.Flux;
  64 import reactor.core.publisher.Mono;
  65
  66 @ExtendWith(MockitoExtension.class)
  67 class RicSynchronizationTaskTest {
  68     private static final String POLICY_TYPE_1_NAME = "type1";
  69     private static final PolicyType POLICY_TYPE_1 = PolicyType.builder() //
  70             .id(POLICY_TYPE_1_NAME) //
  71             .schema("") //
  72             .build();
  73
  74     private static final String RIC_1_NAME = "ric1";
  75
  76     private static Ric ric1;
  77
  78     private static Policy createPolicy(String policyId, boolean isTransient) {
  79         return Policy.builder() //
  80                 .id(policyId) //
  81                 .json("") //
  82                 .ownerServiceId("service") //
  83                 .ric(ric1) //
  84                 .type(POLICY_TYPE_1) //
  85                 .lastModified(Instant.now()) //
  86                 .isTransient(isTransient) //
  87                 .statusNotificationUri("statusNotificationUri") //
  88                 .build();
  89     }
  90
  91     private static Policy policy1;
  92     private static final String SERVICE_1_NAME = "service1";
  93     private static final String SERVICE_1_CALLBACK_URL = "callbackUrl";
  94     private static Service service1;
  95
  96     @Mock
  97     private A1Client a1ClientMock;
  98
  99     @Mock
 100     private A1ClientFactory a1ClientFactoryMock;
 101
 102     private PolicyTypes policyTypes;
 103     private Policies policies;
 104     private Services services;
 105     private Rics rics;
 106
 107     private final ApplicationConfig appConfig = new ApplicationConfig();
 108
 109     @BeforeEach
 110     void init() {
 111         ric1 = new Ric(RicConfig.builder() //
 112                 .ricId(RIC_1_NAME) //
 113                 .baseUrl("baseUrl1") //
 114                 .controllerName("controllerName") //
 115                 .build());
 116         policy1 = createPolicy("policyId1", false);
 117         policyTypes = new PolicyTypes(appConfig);
 118         policies = new Policies(appConfig);
 119         services = new Services(appConfig);
 120         rics = new Rics();
 121
 122         service1 = new Service(SERVICE_1_NAME, Duration.ofSeconds(1), SERVICE_1_CALLBACK_URL);
 123     }
 124
 125     private RicSynchronizationTask createTask() {
 126         ApplicationConfig config = new ApplicationConfig();
 127         AsyncRestClientFactory restClientFactory =
 128                 new AsyncRestClientFactory(config.getWebClientConfig(), new SecurityContext(""));
 129         return new RicSynchronizationTask(a1ClientFactoryMock, policyTypes, policies, services, restClientFactory,
 130                 rics);
 131     };
 132
 133     @Test
 134     void ricAlreadySynchronizing_thenNoSynchronization() {
 135         ric1.setState(RicState.SYNCHRONIZING);
 136         ric1.addSupportedPolicyType(POLICY_TYPE_1);
 137
 138         policyTypes.put(POLICY_TYPE_1);
 139         policies.put(policy1);
 140
 141         RicSynchronizationTask synchronizerUnderTest = createTask();
 142
 143         synchronizerUnderTest.run(ric1);
 144
 145         verifyNoInteractions(a1ClientMock);
 146
 147         assertThat(policyTypes.size()).isEqualTo(1);
 148         assertThat(policies.size()).isEqualTo(1);
 149         assertThat(ric1.getState()).isEqualTo(RicState.SYNCHRONIZING);
 150         assertThat(ric1.getSupportedPolicyTypeNames()).hasSize(1);
 151     }
 152
 153     @Test
 154     void ricIdleAndErrorDeletingPoliciesAllTheTime_thenSynchronizationWithFailedRecovery() {
 155         setUpCreationOfA1Client();
 156         simulateRicWithNoPolicyTypes();
 157         policies.put(policy1);
 158         WebClientResponseException exception = new WebClientResponseException(404, "", null, null, null);
 159         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.error(exception));
 160         RicSynchronizationTask synchronizerUnderTest = createTask();
 161         ric1.setState(RicState.AVAILABLE);
 162         synchronizerUnderTest.run(ric1);
 163         await().untilAsserted(() -> RicState.UNAVAILABLE.equals(ric1.getState()));
 164         assertThat(policies.size()).isZero();
 165         assertThat(ric1.getState()).isEqualTo(RicState.UNAVAILABLE);
 166     }
 167
 168     @Test
 169     void testConnectionError() {
 170         setUpCreationOfA1Client();
 171         simulateRicWithNoPolicyTypes();
 172         policies.put(policy1);
 173         WebClientRequestException exception =
 174                 new WebClientRequestException(new ServiceException("x"), null, null, null);
 175         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.error(exception));
 176         RicSynchronizationTask synchronizerUnderTest = createTask();
 177         ric1.setState(RicState.AVAILABLE);
 178         synchronizerUnderTest.run(ric1);
 179         await().untilAsserted(() -> RicState.UNAVAILABLE.equals(ric1.getState()));
 180     }
 181
 182     @Test
 183     void ricIdlePolicyTypeInRepo_thenSynchronizationWithReuseOfTypeFromRepoAndCorrectServiceNotified() {
 184         rics.put(ric1);
 185         ric1.setState(RicState.AVAILABLE);
 186
 187         policyTypes.put(POLICY_TYPE_1);
 188
 189         services.put(service1);
 190         Service serviceWithoutCallbackUrlShouldNotBeNotified = new Service("service2", Duration.ofSeconds(1), "");
 191         services.put(serviceWithoutCallbackUrlShouldNotBeNotified);
 192
 193         setUpCreationOfA1Client();
 194         simulateRicWithOnePolicyType();
 195
 196         RicSynchronizationTask synchronizerUnderTest = spy(createTask());
 197
 198         ric1.setState(RicState.UNAVAILABLE);
 199         synchronizerUnderTest.run(ric1);
 200         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 201
 202         verify(a1ClientMock, times(1)).getPolicyTypeIdentities();
 203         verifyNoMoreInteractions(a1ClientMock);
 204
 205         verify(synchronizerUnderTest).run(ric1);
 206
 207         assertThat(policyTypes.size()).isEqualTo(1);
 208         assertThat(policies.size()).isZero();
 209         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 210     }
 211
 212     @Test
 213     void ricIdlePolicyTypeNotInRepo_thenSynchronizationWithTypeFromRic() throws Exception {
 214         ric1.setState(RicState.AVAILABLE);
 215         rics.put(ric1);
 216
 217         setUpCreationOfA1Client();
 218         simulateRicWithOnePolicyType();
 219         String typeSchema = "schema";
 220         when(a1ClientMock.getPolicyTypeSchema(POLICY_TYPE_1_NAME)).thenReturn(Mono.just(typeSchema));
 221
 222         RicSynchronizationTask synchronizerUnderTest = createTask();
 223
 224         ric1.setState(RicState.UNAVAILABLE);
 225         synchronizerUnderTest.run(ric1);
 226         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 227
 228         verify(a1ClientMock).getPolicyTypeIdentities();
 229         verifyNoMoreInteractions(a1ClientMock);
 230
 231         assertThat(policyTypes.size()).isEqualTo(1);
 232         assertThat(policyTypes.getType(POLICY_TYPE_1_NAME).getSchema()).isEqualTo(typeSchema);
 233         assertThat(policies.size()).isZero();
 234         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 235     }
 236
 237     @Test
 238     void ricIdleAndHavePolicies_thenSynchronizationWithRecreationOfPolicies() {
 239         ric1.setState(RicState.AVAILABLE);
 240         rics.put(ric1);
 241
 242         Policy transientPolicy = createPolicy("transientPolicyId", true);
 243
 244         policies.put(transientPolicy);
 245         policies.put(policy1);
 246
 247         setUpCreationOfA1Client();
 248         simulateRicWithNoPolicyTypes();
 249
 250         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.just("OK"));
 251         when(a1ClientMock.putPolicy(any(Policy.class))).thenReturn(Mono.just("OK"));
 252
 253         RicSynchronizationTask synchronizerUnderTest = createTask();
 254
 255         ric1.setState(RicState.UNAVAILABLE);
 256         synchronizerUnderTest.run(ric1);
 257         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 258
 259         verify(a1ClientMock).deleteAllPolicies();
 260         verify(a1ClientMock).putPolicy(policy1);
 261         verifyNoMoreInteractions(a1ClientMock);
 262
 263         assertThat(policyTypes.size()).isZero();
 264         assertThat(policies.size()).isEqualTo(1); // The transient policy shall be deleted
 265         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 266     }
 267
 268     private void setUpCreationOfA1Client() {
 269         when(a1ClientFactoryMock.createA1Client(any(Ric.class))).thenReturn(Mono.just(a1ClientMock));
 270         doReturn(Flux.empty()).when(a1ClientMock).deleteAllPolicies();
 271     }
 272
 273     private void simulateRicWithOnePolicyType() {
 274         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Arrays.asList(POLICY_TYPE_1_NAME)));
 275     }
 276
 277     private void simulateRicWithNoPolicyTypes() {
 278         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Collections.emptyList()));
 279     }
 280 }