gerrit.onap Code Review - ccsdk/oran.git/blob

   1 /*-
   2  * ========================LICENSE_START=================================
   3  * ONAP : ccsdk oran
   4  * ======================================================================
   5  * Copyright (C) 2020 Nordix Foundation. All rights reserved.
   6  * ======================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ========================LICENSE_END===================================
  19  */
  20
  21 package org.onap.ccsdk.oran.a1policymanagementservice.tasks;
  22
  23 import static org.assertj.core.api.Assertions.assertThat;
  24 import static org.awaitility.Awaitility.await;
  25 import static org.mockito.ArgumentMatchers.any;
  26 import static org.mockito.Mockito.doReturn;
  27 import static org.mockito.Mockito.spy;
  28 import static org.mockito.Mockito.times;
  29 import static org.mockito.Mockito.verify;
  30 import static org.mockito.Mockito.verifyNoInteractions;
  31 import static org.mockito.Mockito.verifyNoMoreInteractions;
  32 import static org.mockito.Mockito.when;
  33
  34 import java.time.Duration;
  35 import java.time.Instant;
  36 import java.util.Arrays;
  37 import java.util.Collections;
  38
  39 import org.junit.jupiter.api.BeforeEach;
  40 import org.junit.jupiter.api.Test;
  41 import org.junit.jupiter.api.extension.ExtendWith;
  42 import org.mockito.Mock;
  43 import org.mockito.junit.jupiter.MockitoExtension;
  44 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1Client;
  45 import org.onap.ccsdk.oran.a1policymanagementservice.clients.A1ClientFactory;
  46 import org.onap.ccsdk.oran.a1policymanagementservice.clients.AsyncRestClientFactory;
  47 import org.onap.ccsdk.oran.a1policymanagementservice.clients.SecurityContext;
  48 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.ApplicationConfig;
  49 import org.onap.ccsdk.oran.a1policymanagementservice.configuration.RicConfig;
  50 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policies;
  51 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Policy;
  52 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyType;
  53 import org.onap.ccsdk.oran.a1policymanagementservice.repository.PolicyTypes;
  54 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric;
  55 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Ric.RicState;
  56 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Rics;
  57 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Service;
  58 import org.onap.ccsdk.oran.a1policymanagementservice.repository.Services;
  59
  60 import reactor.core.publisher.Flux;
  61 import reactor.core.publisher.Mono;
  62
  63 @ExtendWith(MockitoExtension.class)
  64 class RicSynchronizationTaskTest {
  65     private static final String POLICY_TYPE_1_NAME = "type1";
  66     private static final PolicyType POLICY_TYPE_1 = PolicyType.builder() //
  67             .id(POLICY_TYPE_1_NAME) //
  68             .schema("") //
  69             .build();
  70
  71     private static final String RIC_1_NAME = "ric1";
  72
  73     private static Ric ric1;
  74
  75     private static Policy createPolicy(String policyId, boolean isTransient) {
  76         return Policy.builder() //
  77                 .id(policyId) //
  78                 .json("") //
  79                 .ownerServiceId("service") //
  80                 .ric(ric1) //
  81                 .type(POLICY_TYPE_1) //
  82                 .lastModified(Instant.now()) //
  83                 .isTransient(isTransient) //
  84                 .statusNotificationUri("statusNotificationUri") //
  85                 .build();
  86     }
  87
  88     private static Policy policy1;
  89     private static final String SERVICE_1_NAME = "service1";
  90     private static final String SERVICE_1_CALLBACK_URL = "callbackUrl";
  91     private static Service service1;
  92
  93     @Mock
  94     private A1Client a1ClientMock;
  95
  96     @Mock
  97     private A1ClientFactory a1ClientFactoryMock;
  98
  99     private PolicyTypes policyTypes;
 100     private Policies policies;
 101     private Services services;
 102     private Rics rics;
 103
 104     private final ApplicationConfig appConfig = new ApplicationConfig();
 105
 106     @BeforeEach
 107     void init() {
 108         ric1 = new Ric(RicConfig.builder() //
 109                 .ricId(RIC_1_NAME) //
 110                 .baseUrl("baseUrl1") //
 111                 .controllerName("controllerName") //
 112                 .build());
 113         policy1 = createPolicy("policyId1", false);
 114         policyTypes = new PolicyTypes(appConfig);
 115         policies = new Policies(appConfig);
 116         services = new Services(appConfig);
 117         rics = new Rics();
 118
 119         service1 = new Service(SERVICE_1_NAME, Duration.ofSeconds(1), SERVICE_1_CALLBACK_URL);
 120     }
 121
 122     private RicSynchronizationTask createTask() {
 123         ApplicationConfig config = new ApplicationConfig();
 124         AsyncRestClientFactory restClientFactory =
 125                 new AsyncRestClientFactory(config.getWebClientConfig(), new SecurityContext(""));
 126         return new RicSynchronizationTask(a1ClientFactoryMock, policyTypes, policies, services, restClientFactory,
 127                 rics);
 128     };
 129
 130     @Test
 131     void ricAlreadySynchronizing_thenNoSynchronization() {
 132         ric1.setState(RicState.SYNCHRONIZING);
 133         ric1.addSupportedPolicyType(POLICY_TYPE_1);
 134
 135         policyTypes.put(POLICY_TYPE_1);
 136         policies.put(policy1);
 137
 138         RicSynchronizationTask synchronizerUnderTest = createTask();
 139
 140         synchronizerUnderTest.run(ric1);
 141
 142         verifyNoInteractions(a1ClientMock);
 143
 144         assertThat(policyTypes.size()).isEqualTo(1);
 145         assertThat(policies.size()).isEqualTo(1);
 146         assertThat(ric1.getState()).isEqualTo(RicState.SYNCHRONIZING);
 147         assertThat(ric1.getSupportedPolicyTypeNames()).hasSize(1);
 148     }
 149
 150     @Test
 151     void ricIdlePolicyTypeInRepo_thenSynchronizationWithReuseOfTypeFromRepoAndCorrectServiceNotified() {
 152         rics.put(ric1);
 153         ric1.setState(RicState.AVAILABLE);
 154
 155         policyTypes.put(POLICY_TYPE_1);
 156
 157         services.put(service1);
 158         Service serviceWithoutCallbackUrlShouldNotBeNotified = new Service("service2", Duration.ofSeconds(1), "");
 159         services.put(serviceWithoutCallbackUrlShouldNotBeNotified);
 160
 161         setUpCreationOfA1Client();
 162         simulateRicWithOnePolicyType();
 163
 164         RicSynchronizationTask synchronizerUnderTest = spy(createTask());
 165
 166         ric1.setState(RicState.UNAVAILABLE);
 167         synchronizerUnderTest.run(ric1);
 168         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 169
 170         verify(a1ClientMock, times(1)).getPolicyTypeIdentities();
 171         verifyNoMoreInteractions(a1ClientMock);
 172
 173         verify(synchronizerUnderTest).run(ric1);
 174
 175         assertThat(policyTypes.size()).isEqualTo(1);
 176         assertThat(policies.size()).isZero();
 177         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 178     }
 179
 180     @Test
 181     void ricIdlePolicyTypeNotInRepo_thenSynchronizationWithTypeFromRic() throws Exception {
 182         ric1.setState(RicState.AVAILABLE);
 183         rics.put(ric1);
 184
 185         setUpCreationOfA1Client();
 186         simulateRicWithOnePolicyType();
 187         String typeSchema = "schema";
 188         when(a1ClientMock.getPolicyTypeSchema(POLICY_TYPE_1_NAME)).thenReturn(Mono.just(typeSchema));
 189
 190         RicSynchronizationTask synchronizerUnderTest = createTask();
 191
 192         ric1.setState(RicState.UNAVAILABLE);
 193         synchronizerUnderTest.run(ric1);
 194         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 195
 196         verify(a1ClientMock).getPolicyTypeIdentities();
 197         verifyNoMoreInteractions(a1ClientMock);
 198
 199         assertThat(policyTypes.size()).isEqualTo(1);
 200         assertThat(policyTypes.getType(POLICY_TYPE_1_NAME).getSchema()).isEqualTo(typeSchema);
 201         assertThat(policies.size()).isZero();
 202         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 203     }
 204
 205     @Test
 206     void ricIdleAndHavePolicies_thenSynchronizationWithRecreationOfPolicies() {
 207         ric1.setState(RicState.AVAILABLE);
 208         rics.put(ric1);
 209
 210         Policy transientPolicy = createPolicy("transientPolicyId", true);
 211
 212         policies.put(transientPolicy);
 213         policies.put(policy1);
 214
 215         setUpCreationOfA1Client();
 216         simulateRicWithNoPolicyTypes();
 217
 218         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.just("OK"));
 219         when(a1ClientMock.putPolicy(any(Policy.class))).thenReturn(Mono.just("OK"));
 220
 221         RicSynchronizationTask synchronizerUnderTest = createTask();
 222
 223         ric1.setState(RicState.UNAVAILABLE);
 224         synchronizerUnderTest.run(ric1);
 225         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 226
 227         verify(a1ClientMock).deleteAllPolicies();
 228         verify(a1ClientMock).putPolicy(policy1);
 229         verifyNoMoreInteractions(a1ClientMock);
 230
 231         assertThat(policyTypes.size()).isZero();
 232         assertThat(policies.size()).isEqualTo(1); // The transient policy shall be deleted
 233         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 234     }
 235
 236     @Test
 237     void ricIdleAndErrorDeletingPoliciesFirstTime_thenSynchronizationWithDeletionOfPolicies() {
 238         ric1.setState(RicState.AVAILABLE);
 239         rics.put(ric1);
 240
 241         policies.put(policy1);
 242
 243         setUpCreationOfA1Client();
 244         simulateRicWithNoPolicyTypes();
 245
 246         when(a1ClientMock.deleteAllPolicies()) //
 247                 .thenReturn(Flux.error(new Exception("Exception"))) //
 248                 .thenReturn(Flux.just("OK"));
 249
 250         RicSynchronizationTask synchronizerUnderTest = createTask();
 251
 252         ric1.setState(RicState.UNAVAILABLE);
 253         synchronizerUnderTest.run(ric1);
 254         await().untilAsserted(() -> RicState.AVAILABLE.equals(ric1.getState()));
 255
 256         verify(a1ClientMock, times(2)).deleteAllPolicies();
 257         verifyNoMoreInteractions(a1ClientMock);
 258
 259         assertThat(policyTypes.size()).isZero();
 260         assertThat(policies.size()).isZero();
 261         assertThat(ric1.getState()).isEqualTo(RicState.AVAILABLE);
 262     }
 263
 264     @Test
 265     void ricIdleAndErrorDeletingPoliciesAllTheTime_thenSynchronizationWithFailedRecovery() {
 266         setUpCreationOfA1Client();
 267         simulateRicWithNoPolicyTypes();
 268
 269         policies.put(policy1);
 270
 271         String originalErrorMessage = "Exception";
 272         when(a1ClientMock.deleteAllPolicies()).thenReturn(Flux.error(new Exception(originalErrorMessage)));
 273
 274         RicSynchronizationTask synchronizerUnderTest = createTask();
 275
 276         ric1.setState(RicState.AVAILABLE);
 277         synchronizerUnderTest.run(ric1);
 278         await().untilAsserted(() -> RicState.UNAVAILABLE.equals(ric1.getState()));
 279
 280         verify(a1ClientMock, times(2)).deleteAllPolicies();
 281         verifyNoMoreInteractions(a1ClientMock);
 282
 283         assertThat(policyTypes.size()).isZero();
 284         assertThat(policies.size()).isZero();
 285         assertThat(ric1.getState()).isEqualTo(RicState.UNAVAILABLE);
 286     }
 287
 288     private void setUpCreationOfA1Client() {
 289         when(a1ClientFactoryMock.createA1Client(any(Ric.class))).thenReturn(Mono.just(a1ClientMock));
 290         doReturn(Flux.empty()).when(a1ClientMock).deleteAllPolicies();
 291     }
 292
 293     private void simulateRicWithOnePolicyType() {
 294         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Arrays.asList(POLICY_TYPE_1_NAME)));
 295     }
 296
 297     private void simulateRicWithNoPolicyTypes() {
 298         when(a1ClientMock.getPolicyTypeIdentities()).thenReturn(Mono.just(Collections.emptyList()));
 299     }
 300 }