gerrit.onap Code Review - sdc.git/blob

   1 /*
   2  * ============LICENSE_START=======================================================
   3  *  Copyright (C) 2020 Nordix Foundation
   4  *  ================================================================================
   5  *  Licensed under the Apache License, Version 2.0 (the "License");
   6  *  you may not use this file except in compliance with the License.
   7  *  You may obtain a copy of the License at
   8  *
   9  *        http://www.apache.org/licenses/LICENSE-2.0
  10  *  Unless required by applicable law or agreed to in writing, software
  11  *  distributed under the License is distributed on an "AS IS" BASIS,
  12  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13  *  See the License for the specific language governing permissions and
  14  *  limitations under the License.
  15  *
  16  *  SPDX-License-Identifier: Apache-2.0
  17  *  ============LICENSE_END=========================================================
  18  */
  19
  20 package org.openecomp.sdc.be.components.impl;
  21
  22 import static org.assertj.core.api.Assertions.assertThat;
  23 import static org.junit.jupiter.api.Assertions.assertThrows;
  24 import static org.junit.jupiter.api.Assertions.fail;
  25 import static org.mockito.ArgumentMatchers.any;
  26 import static org.mockito.ArgumentMatchers.anyInt;
  27 import static org.mockito.ArgumentMatchers.anyList;
  28 import static org.mockito.ArgumentMatchers.anyString;
  29 import static org.mockito.Mockito.times;
  30 import static org.mockito.Mockito.verify;
  31 import static org.mockito.Mockito.when;
  32
  33 import fj.data.Either;
  34 import java.util.Arrays;
  35 import java.util.Collections;
  36 import java.util.LinkedList;
  37 import java.util.List;
  38 import java.util.Optional;
  39
  40 import org.junit.jupiter.api.BeforeEach;
  41 import org.junit.jupiter.api.Test;
  42 import org.junit.jupiter.api.extension.ExtendWith;
  43 import org.mockito.InjectMocks;
  44 import org.mockito.Mock;
  45 import org.mockito.MockitoAnnotations;
  46 import org.mockito.junit.jupiter.MockitoExtension;
  47 import org.openecomp.sdc.be.components.impl.exceptions.BusinessLogicException;
  48 import org.openecomp.sdc.be.components.impl.utils.NodeFilterConstraintAction;
  49 import org.openecomp.sdc.be.components.validation.NodeFilterValidator;
  50 import org.openecomp.sdc.be.components.validation.UserValidations;
  51 import org.openecomp.sdc.be.dao.janusgraph.JanusGraphGenericDao;
  52 import org.openecomp.sdc.be.dao.jsongraph.JanusGraphDao;
  53 import org.openecomp.sdc.be.datamodel.utils.ConstraintConvertor;
  54 import org.openecomp.sdc.be.datatypes.elements.ListDataDefinition;
  55 import org.openecomp.sdc.be.datatypes.elements.RequirementSubstitutionFilterPropertyDataDefinition;
  56 import org.openecomp.sdc.be.datatypes.elements.SubstitutionFilterDataDefinition;
  57 import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum;
  58 import org.openecomp.sdc.be.datatypes.enums.NodeTypeEnum;
  59 import org.openecomp.sdc.be.impl.ComponentsUtils;
  60 import org.openecomp.sdc.be.model.Component;
  61 import org.openecomp.sdc.be.model.Resource;
  62 import org.openecomp.sdc.be.model.Service;
  63 import org.openecomp.sdc.be.model.PropertyDefinition;
  64 import org.openecomp.sdc.be.model.jsonjanusgraph.operations.SubstitutionFilterOperation;
  65 import org.openecomp.sdc.be.model.jsonjanusgraph.operations.ToscaOperationFacade;
  66 import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
  67 import org.openecomp.sdc.be.model.operations.impl.GraphLockOperation;
  68 import org.openecomp.sdc.be.ui.model.UIConstraint;
  69
  70 @ExtendWith(MockitoExtension.class)
  71 public class ComponentSubstitutionFilterBusinessLogicTest extends BaseBusinessLogicMock {
  72
  73     private static final String servicePropertyName = "controller_actor";
  74     private static final String constraintOperator = "equal";
  75     private static final String sourceType = "static";
  76     private static final String sourceName = sourceType;
  77     private static final String propertyValue = "constraintValue";
  78     private static final String componentId = "dac65869-dfb4-40d2-aa20-084324659ec1";
  79
  80     @InjectMocks
  81     private ComponentSubstitutionFilterBusinessLogic componentSubstitutionFilterBusinessLogic;
  82     @Mock
  83     private SubstitutionFilterOperation substitutionFilterOperation;
  84     @Mock
  85     private ToscaOperationFacade toscaOperationFacade;
  86     @Mock
  87     private GraphLockOperation graphLockOperation;
  88     @Mock
  89     private JanusGraphDao janusGraphDao;
  90     @Mock
  91     private JanusGraphGenericDao janusGraphGenericDao;
  92     @Mock
  93     private ComponentsUtils componentsUtils;
  94     @Mock
  95     private UserValidations userValidations;
  96     @Mock
  97     private NodeFilterValidator nodeFilterValidator;
  98
  99     private Component component;
 100     private SubstitutionFilterDataDefinition substitutionFilterDataDefinition;
 101     private RequirementSubstitutionFilterPropertyDataDefinition requirementSubstitutionFilterPropertyDataDefinition;
 102     private String constraint;
 103
 104     @BeforeEach
 105     public void init() {
 106         MockitoAnnotations.initMocks(this);
 107         componentSubstitutionFilterBusinessLogic =
 108             new ComponentSubstitutionFilterBusinessLogic(elementDao, groupOperation, groupInstanceOperation,
 109                 groupTypeOperation, interfaceOperation, interfaceLifecycleTypeOperation, artifactToscaOperation,
 110                 substitutionFilterOperation, nodeFilterValidator);
 111         componentSubstitutionFilterBusinessLogic.setToscaOperationFacade(toscaOperationFacade);
 112         componentSubstitutionFilterBusinessLogic.setGraphLockOperation(graphLockOperation);
 113         componentSubstitutionFilterBusinessLogic.setComponentsUtils(componentsUtils);
 114         componentSubstitutionFilterBusinessLogic.setUserValidations(userValidations);
 115         componentSubstitutionFilterBusinessLogic.setJanusGraphGenericDao(janusGraphGenericDao);
 116         componentSubstitutionFilterBusinessLogic.setJanusGraphDao(janusGraphDao);
 117
 118         initResource();
 119     }
 120
 121     @Test
 122     public void doNotCreateSubstitutionFilterAsExistsTest() throws BusinessLogicException {
 123         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 124
 125         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 126
 127         final Optional<SubstitutionFilterDataDefinition> result = componentSubstitutionFilterBusinessLogic
 128                 .createSubstitutionFilterIfNotExist(componentId, true, ComponentTypeEnum.SERVICE);
 129         assertThat(result).isPresent();
 130         assertThat(result.get().getProperties()).isEqualTo(substitutionFilterDataDefinition.getProperties());
 131         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 132     }
 133
 134     @Test
 135     public void createSubstitutionFilterIfNotExistTest() throws BusinessLogicException {
 136         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 137         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 138                 .thenReturn(StorageOperationStatus.OK);
 139         when(substitutionFilterOperation.createSubstitutionFilter(componentId))
 140                 .thenReturn(Either.left(substitutionFilterDataDefinition));
 141         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 142                 .thenReturn(StorageOperationStatus.OK);
 143
 144         final Optional<SubstitutionFilterDataDefinition> result = componentSubstitutionFilterBusinessLogic
 145                 .createSubstitutionFilterIfNotExist(componentId, true, ComponentTypeEnum.SERVICE);
 146         assertThat(result).isPresent();
 147         assertThat(result.get().getProperties()).isEqualTo(substitutionFilterDataDefinition.getProperties());
 148         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 149         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 150         verify(substitutionFilterOperation, times(1)).createSubstitutionFilter(componentId);
 151         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 152     }
 153
 154     @Test
 155     public void createSubstitutionFilterIfNotExistFailTest() {
 156         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 157         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 158                 .thenReturn(StorageOperationStatus.OK);
 159         when(substitutionFilterOperation.createSubstitutionFilter(componentId))
 160                 .thenReturn(Either.right(StorageOperationStatus.GENERAL_ERROR));
 161         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 162                 .thenReturn(StorageOperationStatus.OK);
 163
 164         assertThrows(BusinessLogicException.class, () -> componentSubstitutionFilterBusinessLogic
 165                 .createSubstitutionFilterIfNotExist(componentId, true, ComponentTypeEnum.SERVICE));
 166
 167         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 168         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 169         verify(substitutionFilterOperation, times(1)).createSubstitutionFilter(componentId);
 170         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 171     }
 172
 173     @Test
 174     public void addSubstitutionFilterTest() throws BusinessLogicException {
 175         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 176
 177         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 178         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 179             .thenReturn(StorageOperationStatus.OK);
 180         when(nodeFilterValidator.validateComponentFilter(component, Collections.singletonList(constraint),
 181                 NodeFilterConstraintAction.ADD)).thenReturn(Either.left(true));
 182         when(substitutionFilterOperation
 183             .addPropertyFilter(anyString(), any(SubstitutionFilterDataDefinition.class),
 184                 any(RequirementSubstitutionFilterPropertyDataDefinition.class)))
 185             .thenReturn(Either.left(substitutionFilterDataDefinition));
 186         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 187             .thenReturn(StorageOperationStatus.OK);
 188
 189         final Optional<SubstitutionFilterDataDefinition> result = componentSubstitutionFilterBusinessLogic
 190                 .addSubstitutionFilter(componentId, servicePropertyName, constraint, true,
 191                         ComponentTypeEnum.SERVICE);
 192
 193         assertThat(result).isPresent();
 194         assertThat(result.get().getProperties().getListToscaDataDefinition()).hasSize(1);
 195         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 196         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 197         verify(nodeFilterValidator, times(1)).validateComponentFilter(component,
 198                 Collections.singletonList(constraint), NodeFilterConstraintAction.ADD);
 199         verify(substitutionFilterOperation, times(1))
 200             .addPropertyFilter(anyString(), any(SubstitutionFilterDataDefinition.class),
 201                     any(RequirementSubstitutionFilterPropertyDataDefinition.class));
 202         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 203
 204     }
 205
 206     @Test
 207     public void addSubstitutionFilterFailTest() {
 208         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 209
 210         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 211         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 212             .thenReturn(StorageOperationStatus.OK);
 213         when(nodeFilterValidator.validateComponentFilter(component, Collections.singletonList(constraint),
 214                 NodeFilterConstraintAction.ADD)).thenReturn(Either.left(true));
 215         when(substitutionFilterOperation
 216             .addPropertyFilter(componentId, substitutionFilterDataDefinition,
 217                     requirementSubstitutionFilterPropertyDataDefinition))
 218             .thenReturn(Either.right(StorageOperationStatus.GENERAL_ERROR));
 219
 220         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 221             .thenReturn(StorageOperationStatus.OK);
 222
 223         assertThrows(BusinessLogicException.class, () -> componentSubstitutionFilterBusinessLogic
 224                 .addSubstitutionFilter(componentId, servicePropertyName, constraint, true,
 225                         ComponentTypeEnum.SERVICE));
 226
 227         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 228         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 229         verify(nodeFilterValidator, times(1)).validateComponentFilter(component,
 230                 Collections.singletonList(constraint), NodeFilterConstraintAction.ADD);
 231         verify(substitutionFilterOperation, times(0))
 232             .addPropertyFilter(componentId, substitutionFilterDataDefinition,
 233                 requirementSubstitutionFilterPropertyDataDefinition);
 234         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 235     }
 236
 237     @Test
 238     public void updateSubstitutionFilterTest() throws BusinessLogicException {
 239         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 240         final List<String> constraints = requirementSubstitutionFilterPropertyDataDefinition.getConstraints();
 241
 242         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 243         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 244             .thenReturn(StorageOperationStatus.OK);
 245         when(nodeFilterValidator.validateComponentFilter(component, Collections.singletonList(constraint),
 246                 NodeFilterConstraintAction.UPDATE)).thenReturn(Either.left(true));
 247         when(substitutionFilterOperation.updateProperties(anyString(), any(SubstitutionFilterDataDefinition.class), anyList()))
 248                 .thenReturn(Either.left(substitutionFilterDataDefinition));
 249         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 250             .thenReturn(StorageOperationStatus.OK);
 251
 252         final Optional<SubstitutionFilterDataDefinition> result = componentSubstitutionFilterBusinessLogic
 253             .updateSubstitutionFilter(componentId, Collections.singletonList(constraint),
 254                 true, ComponentTypeEnum.SERVICE);
 255
 256         assertThat(result).isPresent();
 257         assertThat(result.get().getProperties().getListToscaDataDefinition()).hasSize(1);
 258         verify(substitutionFilterOperation, times(1))
 259                 .updateProperties(anyString(), any(SubstitutionFilterDataDefinition.class), anyList());
 260         verify(nodeFilterValidator, times(1)).validateComponentFilter(component,
 261                 Collections.singletonList(constraint), NodeFilterConstraintAction.UPDATE);
 262         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 263         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 264         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 265     }
 266
 267     @Test
 268     public void updateSubstitutionFilterFailTest() {
 269         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 270
 271         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 272         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 273             .thenReturn(StorageOperationStatus.OK);
 274         when(nodeFilterValidator.validateComponentFilter(component, Collections.singletonList(constraint),
 275                 NodeFilterConstraintAction.UPDATE)).thenReturn(Either.left(true));
 276         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 277             .thenReturn(StorageOperationStatus.OK);
 278
 279         final List<String> constraints = requirementSubstitutionFilterPropertyDataDefinition.getConstraints();
 280         assertThrows(BusinessLogicException.class, () -> componentSubstitutionFilterBusinessLogic
 281             .updateSubstitutionFilter(componentId, constraints, true, ComponentTypeEnum.SERVICE));
 282
 283         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 284         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 285         verify(nodeFilterValidator, times(1)).validateComponentFilter(component,
 286                 Collections.singletonList(constraint), NodeFilterConstraintAction.UPDATE);
 287         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 288     }
 289
 290     @Test
 291     public void deleteSubstitutionFilterTest() throws BusinessLogicException {
 292         substitutionFilterDataDefinition.setProperties(new ListDataDefinition<>());
 293         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 294
 295         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 296         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 297             .thenReturn(StorageOperationStatus.OK);
 298         when(substitutionFilterOperation.deleteConstraint(anyString(), any(SubstitutionFilterDataDefinition.class), anyInt()))
 299             .thenReturn(Either.left(substitutionFilterDataDefinition));
 300         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 301             .thenReturn(StorageOperationStatus.OK);
 302
 303         final Optional<SubstitutionFilterDataDefinition> result = componentSubstitutionFilterBusinessLogic
 304                 .deleteSubstitutionFilter(componentId, anyInt(), true, ComponentTypeEnum.SERVICE);
 305
 306         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 307         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 308         verify(substitutionFilterOperation, times(1)).deleteConstraint(componentId,
 309                 substitutionFilterDataDefinition, 0);
 310         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 311     }
 312
 313     @Test
 314     public void deleteSubstitutionFilterFailTest() {
 315         component.setSubstitutionFilter(substitutionFilterDataDefinition);
 316
 317         when(toscaOperationFacade.getToscaElement(componentId)).thenReturn(Either.left(component));
 318         when(graphLockOperation.lockComponent(componentId, NodeTypeEnum.Service))
 319             .thenReturn(StorageOperationStatus.OK);
 320         when(substitutionFilterOperation.deleteConstraint(anyString(),
 321             any(SubstitutionFilterDataDefinition.class), anyInt()))
 322             .thenReturn(Either.right(StorageOperationStatus.GENERAL_ERROR));
 323         when(graphLockOperation.unlockComponent(componentId, NodeTypeEnum.Service))
 324             .thenReturn(StorageOperationStatus.OK);
 325
 326         final List<String> constraints = requirementSubstitutionFilterPropertyDataDefinition.getConstraints();
 327         assertThrows(BusinessLogicException.class, () -> componentSubstitutionFilterBusinessLogic
 328                 .deleteSubstitutionFilter(componentId, anyInt(),true, ComponentTypeEnum.SERVICE));
 329
 330         verify(toscaOperationFacade, times(1)).getToscaElement(componentId);
 331         verify(graphLockOperation, times(1)).lockComponent(componentId, NodeTypeEnum.Service);
 332         verify(substitutionFilterOperation, times(1)).deleteConstraint(componentId,
 333                 substitutionFilterDataDefinition, 0);
 334         verify(graphLockOperation, times(1)).unlockComponent(componentId, NodeTypeEnum.Service);
 335     }
 336
 337     public void initResource() {
 338         try {
 339             component = new Service();
 340             component.setName("MyTestService");
 341             component.setUniqueId(componentId);
 342
 343             final UIConstraint uiConstraint =
 344                 new UIConstraint(servicePropertyName, constraintOperator, sourceType, sourceName, propertyValue);
 345             constraint = new ConstraintConvertor().convert(uiConstraint);
 346
 347             requirementSubstitutionFilterPropertyDataDefinition = new RequirementSubstitutionFilterPropertyDataDefinition();
 348             requirementSubstitutionFilterPropertyDataDefinition.setName(uiConstraint.getServicePropertyName());
 349             requirementSubstitutionFilterPropertyDataDefinition
 350                 .setConstraints(Collections.singletonList(constraint));
 351
 352             final ListDataDefinition<RequirementSubstitutionFilterPropertyDataDefinition> listDataDefinition =
 353                 new ListDataDefinition<>(
 354                     Collections.singletonList(requirementSubstitutionFilterPropertyDataDefinition));
 355
 356             substitutionFilterDataDefinition = new SubstitutionFilterDataDefinition();
 357             substitutionFilterDataDefinition.setProperties(listDataDefinition);
 358             substitutionFilterDataDefinition.setID("SUBSTITUTION_FILTER_UID");
 359
 360             final PropertyDefinition property = new PropertyDefinition();
 361             property.setName(uiConstraint.getServicePropertyName());
 362
 363             component.setProperties(new LinkedList<>(Arrays.asList(property)));
 364         } catch (final Exception e) {
 365             fail(e.getMessage());
 366         }
 367     }
 368 }