catalog-model/src/main/java/org/openecomp/sdc/be/model/jsonjanusgraph/operations/GroupsOperation.java

   1 /*-
   2  * ============LICENSE_START=======================================================
   3  * SDC
   4  * ================================================================================
   5  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
   6  * ================================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ============LICENSE_END=========================================================
  19  */
  20 package org.openecomp.sdc.be.model.jsonjanusgraph.operations;
  21
  22 import fj.data.Either;
  23 import java.util.ArrayList;
  24 import java.util.List;
  25 import java.util.Map;
  26 import java.util.Map.Entry;
  27 import java.util.Optional;
  28 import java.util.UUID;
  29 import java.util.stream.Collectors;
  30 import org.apache.commons.collections.MapUtils;
  31 import org.openecomp.sdc.be.dao.janusgraph.JanusGraphOperationStatus;
  32 import org.openecomp.sdc.be.dao.jsongraph.GraphVertex;
  33 import org.openecomp.sdc.be.dao.jsongraph.types.EdgeLabelEnum;
  34 import org.openecomp.sdc.be.dao.jsongraph.types.JsonParseFlagEnum;
  35 import org.openecomp.sdc.be.dao.jsongraph.types.VertexTypeEnum;
  36 import org.openecomp.sdc.be.datatypes.elements.GroupDataDefinition;
  37 import org.openecomp.sdc.be.datatypes.elements.GroupInstanceDataDefinition;
  38 import org.openecomp.sdc.be.datatypes.elements.MapCapabilityProperty;
  39 import org.openecomp.sdc.be.datatypes.elements.MapListCapabilityDataDefinition;
  40 import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition;
  41 import org.openecomp.sdc.be.datatypes.enums.JsonPresentationFields;
  42 import org.openecomp.sdc.be.datatypes.enums.PromoteVersionEnum;
  43 import org.openecomp.sdc.be.model.Component;
  44 import org.openecomp.sdc.be.model.GroupDefinition;
  45 import org.openecomp.sdc.be.model.GroupInstance;
  46 import org.openecomp.sdc.be.model.GroupInstanceProperty;
  47 import org.openecomp.sdc.be.model.GroupProperty;
  48 import org.openecomp.sdc.be.model.jsonjanusgraph.utils.ModelConverter;
  49 import org.openecomp.sdc.be.model.operations.StorageException;
  50 import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
  51 import org.openecomp.sdc.be.model.operations.impl.DaoStatusConverter;
  52 import org.openecomp.sdc.be.model.utils.GroupUtils;
  53 import org.openecomp.sdc.common.jsongraph.util.CommonUtility;
  54 import org.openecomp.sdc.common.jsongraph.util.CommonUtility.LogLevelEnum;
  55 import org.openecomp.sdc.common.log.wrappers.Logger;
  56
  57 @org.springframework.stereotype.Component("groups-operation")
  58 public class GroupsOperation extends BaseOperation {
  59
  60     private static final Logger log = Logger.getLogger(GroupsOperation.class.getName());
  61
  62     public StorageOperationStatus deleteCalculatedCapabilitiesWithProperties(String componentId, List<GroupDefinition> groupDefinitions) {
  63         Optional<StorageOperationStatus> error = groupDefinitions.stream()
  64             .map(g -> removeCalculatedCapabilityFromComponent(componentId, g.getUniqueId())).filter(status -> status != StorageOperationStatus.OK)
  65             .findFirst();
  66         if (!error.isPresent()) {
  67             Map<String, MapCapabilityProperty> extractCapabilityPropertiesFromGroups = ModelConverter
  68                 .extractCapabilityPropertiesFromGroups(groupDefinitions, false);
  69             error = extractCapabilityPropertiesFromGroups.keySet().stream()
  70                 .map(k -> removeCalculatedCapabilityPropertiesFromComponent(componentId, k)).filter(status -> status != StorageOperationStatus.OK)
  71                 .findFirst();
  72         }
  73         if (error.isPresent()) {
  74             return error.get();
  75         }
  76         return StorageOperationStatus.OK;
  77     }
  78
  79     /**
  80      * Adds the map of the calculated capabilities and the map of the calculated capabilities properties the the component on the graph
  81      *
  82      * @param componentId
  83      * @param calculatedCapabilities
  84      * @param calculatedCapabilitiesProperties
  85      * @return status of the result the operation
  86      */
  87     public StorageOperationStatus addCalculatedCapabilitiesWithProperties(String componentId,
  88                                                                           Map<String, MapListCapabilityDataDefinition> calculatedCapabilities,
  89                                                                           Map<String, MapCapabilityProperty> calculatedCapabilitiesProperties) {
  90         Optional<StorageOperationStatus> error = calculatedCapabilities.entrySet().stream()
  91             .map(e -> addElementToComponent(componentId, VertexTypeEnum.CALCULATED_CAPABILITIES, EdgeLabelEnum.CALCULATED_CAPABILITIES, e))
  92             .filter(status -> status != StorageOperationStatus.OK).findFirst();
  93         if (!error.isPresent()) {
  94             error = calculatedCapabilitiesProperties.entrySet().stream().map(e -> addCalculatedCapabilityPropertiesToComponent(componentId, e))
  95                 .filter(status -> status != StorageOperationStatus.OK).findFirst();
  96         }
  97         if (error.isPresent()) {
  98             return error.get();
  99         }
 100         return StorageOperationStatus.OK;
 101     }
 102
 103     public StorageOperationStatus updateCalculatedCapabilitiesWithProperties(String componentId,
 104                                                                              Map<String, MapListCapabilityDataDefinition> calculatedCapabilities,
 105                                                                              Map<String, MapCapabilityProperty> calculatedCapabilitiesProperties) {
 106         Optional<StorageOperationStatus> error = calculatedCapabilities.entrySet().stream()
 107             .map(e -> updateCalculatedCapabilityOfComponent(componentId, e)).filter(status -> status != StorageOperationStatus.OK).findFirst();
 108         if (!error.isPresent()) {
 109             error = calculatedCapabilitiesProperties.entrySet().stream().map(e -> updateCalculatedCapabilityPropertiesOnComponent(componentId, e))
 110                 .filter(status -> status != StorageOperationStatus.OK).findFirst();
 111         }
 112         if (error.isPresent()) {
 113             return error.get();
 114         }
 115         return StorageOperationStatus.OK;
 116     }
 117
 118     private StorageOperationStatus updateCalculatedCapabilityOfComponent(String componentId,
 119                                                                          Entry<String, MapListCapabilityDataDefinition> capabilities) {
 120         if (MapUtils.isNotEmpty(capabilities.getValue().getMapToscaDataDefinition())) {
 121             return updateToscaDataDeepElementsBlockToToscaElement(componentId, EdgeLabelEnum.CALCULATED_CAPABILITIES, capabilities.getValue(),
 122                 capabilities.getKey());
 123         }
 124         return StorageOperationStatus.OK;
 125     }
 126
 127     private StorageOperationStatus addCalculatedCapabilityPropertiesToComponent(String componentId, Entry<String, MapCapabilityProperty> properties) {
 128         if (MapUtils.isNotEmpty(properties.getValue().getMapToscaDataDefinition())) {
 129             return addToscaDataDeepElementsBlockToToscaElement(componentId, EdgeLabelEnum.CALCULATED_CAP_PROPERTIES,
 130                 VertexTypeEnum.CALCULATED_CAP_PROPERTIES, properties.getValue(), properties.getKey());
 131         }
 132         return StorageOperationStatus.OK;
 133     }
 134
 135     private StorageOperationStatus updateCalculatedCapabilityPropertiesOnComponent(String componentId,
 136                                                                                    Entry<String, MapCapabilityProperty> properties) {
 137         if (MapUtils.isNotEmpty(properties.getValue().getMapToscaDataDefinition())) {
 138             return updateToscaDataDeepElementsBlockToToscaElement(componentId, EdgeLabelEnum.CALCULATED_CAP_PROPERTIES, properties.getValue(),
 139                 properties.getKey());
 140         }
 141         return StorageOperationStatus.OK;
 142     }
 143
 144     private StorageOperationStatus removeCalculatedCapabilityFromComponent(String componentId, String groupId) {
 145         return deleteToscaDataDeepElementsBlockOfToscaElement(componentId, EdgeLabelEnum.CALCULATED_CAPABILITIES,
 146             groupId);
 147     }
 148
 149     private StorageOperationStatus removeCalculatedCapabilityPropertiesFromComponent(String componentId, String groupId) {
 150         return deleteToscaDataDeepElementsBlockOfToscaElement(componentId, EdgeLabelEnum.CALCULATED_CAP_PROPERTIES,
 151             groupId);
 152     }
 153
 154     public Either<List<GroupDefinition>, StorageOperationStatus> createGroups(Component component, Map<String, GroupDataDefinition> groups) {
 155         Either<List<GroupDefinition>, StorageOperationStatus> result = null;
 156         Either<GraphVertex, JanusGraphOperationStatus> getComponentVertex = null;
 157         StorageOperationStatus status = null;
 158         getComponentVertex = janusGraphDao.getVertexById(component.getUniqueId(), JsonParseFlagEnum.NoParse);
 159         if (getComponentVertex.isRight()) {
 160             result = Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getComponentVertex.right().value()));
 161         }
 162         if (result == null) {
 163             status = topologyTemplateOperation.associateGroupsToComponent(getComponentVertex.left().value(), groups);
 164             if (status != StorageOperationStatus.OK) {
 165                 result = Either.right(status);
 166             }
 167         }
 168         if (result == null) {
 169             result = Either.left(ModelConverter.convertToGroupDefinitions(groups));
 170         }
 171         return result;
 172     }
 173
 174     public <T extends GroupDataDefinition> Either<List<GroupDefinition>, StorageOperationStatus> addGroups(Component component, List<T> groups) {
 175         Either<List<GroupDefinition>, StorageOperationStatus> result = null;
 176         Either<GraphVertex, JanusGraphOperationStatus> getComponentVertex;
 177         StorageOperationStatus status;
 178         getComponentVertex = janusGraphDao.getVertexById(component.getUniqueId(), JsonParseFlagEnum.NoParse);
 179         if (getComponentVertex.isRight()) {
 180             result = Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getComponentVertex.right().value()));
 181         }
 182         if (result == null) {
 183             status = addToscaDataToToscaElement(component.getUniqueId(), EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS, groups,
 184                 JsonPresentationFields.CI_INVARIANT_NAME);
 185             if (status != StorageOperationStatus.OK) {
 186                 result = Either.right(status);
 187             }
 188         }
 189         if (result == null) {
 190             Map<String, GroupDataDefinition> mapGroup = groups.stream().collect(Collectors.toMap(GroupDataDefinition::getInvariantName, x -> x));
 191             result = Either.left(ModelConverter.convertToGroupDefinitions(mapGroup));
 192         }
 193         return result;
 194     }
 195
 196     public Either<List<GroupDefinition>, StorageOperationStatus> deleteGroups(Component component, List<GroupDataDefinition> groups) {
 197         Either<List<GroupDefinition>, StorageOperationStatus> result = null;
 198         Either<GraphVertex, JanusGraphOperationStatus> getComponentVertex = null;
 199         StorageOperationStatus status = null;
 200         getComponentVertex = janusGraphDao.getVertexById(component.getUniqueId(), JsonParseFlagEnum.NoParse);
 201         if (getComponentVertex.isRight()) {
 202             result = Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getComponentVertex.right().value()));
 203         }
 204         if (result == null) {
 205             List<String> groupInvariantName = groups.stream().map(GroupDataDefinition::getInvariantName).collect(Collectors.toList());
 206             status = deleteToscaDataElements(component.getUniqueId(), EdgeLabelEnum.GROUPS, groupInvariantName);
 207             if (status != StorageOperationStatus.OK) {
 208                 result = Either.right(status);
 209             }
 210         }
 211         if (result == null) {
 212             Map<String, GroupDataDefinition> mapGroup = groups.stream().collect(Collectors.toMap(GroupDataDefinition::getName, x -> x));
 213             result = Either.left(ModelConverter.convertToGroupDefinitions(mapGroup));
 214         }
 215         return result;
 216     }
 217
 218     public <T extends GroupDataDefinition> Either<List<GroupDefinition>, StorageOperationStatus> updateGroups(Component component, List<T> groups,
 219                                                                                                               PromoteVersionEnum promoteVersion) {
 220         Either<List<GroupDefinition>, StorageOperationStatus> result = null;
 221         Either<GraphVertex, JanusGraphOperationStatus> getComponentVertex = null;
 222         StorageOperationStatus status = null;
 223         getComponentVertex = janusGraphDao.getVertexById(component.getUniqueId(), JsonParseFlagEnum.NoParse);
 224         if (getComponentVertex.isRight()) {
 225             result = Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getComponentVertex.right().value()));
 226         }
 227         if (result == null) {
 228             groups.forEach(gr -> updateVersion(promoteVersion, gr));
 229             status = updateToscaDataOfToscaElement(component.getUniqueId(), EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS, groups,
 230                 JsonPresentationFields.CI_INVARIANT_NAME);
 231             if (status != StorageOperationStatus.OK) {
 232                 result = Either.right(status);
 233             }
 234         }
 235         if (result == null) {
 236             Map<String, GroupDataDefinition> mapGroup = groups.stream().collect(Collectors.toMap(GroupDataDefinition::getInvariantName, x -> x));
 237             result = Either.left(ModelConverter.convertToGroupDefinitions(mapGroup));
 238             updateGroupsOnComponent(component, ModelConverter.convertToGroupDefinitions(mapGroup));
 239         }
 240         return result;
 241     }
 242
 243     private void updateGroupsOnComponent(Component component, List<GroupDefinition> groupsToUpdate) {
 244         List<GroupDefinition> groupsFromResource = component.getGroups();
 245         for (GroupDefinition group : groupsToUpdate) {
 246             Optional<GroupDefinition> op = groupsFromResource.stream().filter(p -> p.getInvariantName().equalsIgnoreCase(group.getInvariantName()))
 247                 .findAny();
 248             if (op.isPresent()) {
 249                 GroupDefinition groupToUpdate = op.get();
 250                 groupToUpdate.setMembers(group.getMembers());
 251                 groupToUpdate.setCapabilities(group.getCapabilities());
 252                 groupToUpdate.setProperties(group.getProperties());
 253             }
 254         }
 255     }
 256
 257     private <T extends GroupDataDefinition> void updateVersion(PromoteVersionEnum promoteVersion, T group) {
 258         group.setVersion(GroupUtils.updateVersion(promoteVersion, group.getVersion()));
 259     }
 260
 261     public void updateGroupOnComponent(String componentId, GroupDefinition groupDefinition, PromoteVersionEnum promoteMinorVersion) {
 262         GraphVertex componentVertex = janusGraphDao.getVertexById(componentId, JsonParseFlagEnum.ParseMetadata).left().on(this::onJanusGraphError);
 263         updateVersion(promoteMinorVersion, groupDefinition);
 264         StorageOperationStatus updateToscaResult = updateToscaDataOfToscaElement(componentVertex, EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS,
 265             groupDefinition, JsonPresentationFields.CI_INVARIANT_NAME);
 266         if (StorageOperationStatus.OK != updateToscaResult) {
 267             throw new StorageException(updateToscaResult, groupDefinition.getUniqueId());
 268         }
 269         updateLastUpdateDate(componentVertex);
 270     }
 271
 272     public <T extends GroupDataDefinition> StorageOperationStatus updateGroupsOnComponent(String componentId, List<T> groups) {
 273         GraphVertex componentVertex = janusGraphDao.getVertexById(componentId, JsonParseFlagEnum.ParseMetadata).left().on(this::onJanusGraphError);
 274         StorageOperationStatus updateToscaResult = updateToscaDataOfToscaElement(componentVertex, EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS, groups,
 275             JsonPresentationFields.CI_INVARIANT_NAME);
 276         if (StorageOperationStatus.OK != updateToscaResult) {
 277             throw new StorageException(updateToscaResult);
 278         }
 279         updateLastUpdateDate(componentVertex);
 280         return updateToscaResult;
 281     }
 282
 283     private void updateLastUpdateDate(GraphVertex componentVertex) {
 284         componentVertex.setJsonMetadataField(JsonPresentationFields.LAST_UPDATE_DATE, System.currentTimeMillis());
 285         janusGraphDao.updateVertex(componentVertex).left().on(this::onJanusGraphError);
 286     }
 287
 288     GraphVertex onJanusGraphError(JanusGraphOperationStatus janusGraphOperationStatus) {
 289         throw new StorageException(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(janusGraphOperationStatus));
 290     }
 291
 292     public Either<List<GroupProperty>, StorageOperationStatus> updateGroupPropertiesOnComponent(String componentId, GroupDefinition group,
 293                                                                                                 List<GroupProperty> newGroupProperties,
 294                                                                                                 PromoteVersionEnum promoteMinorVersion) {
 295         Either<GraphVertex, JanusGraphOperationStatus> getComponentVertex = janusGraphDao.getVertexById(componentId, JsonParseFlagEnum.ParseMetadata);
 296         if (getComponentVertex.isRight()) {
 297             CommonUtility.addRecordToLog(log, LogLevelEnum.DEBUG, "Failed to fetch component {}. Status is {} ", componentId);
 298             return Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getComponentVertex.right().value()));
 299         }
 300         GraphVertex componentVertex = getComponentVertex.left().value();
 301         //update
 302         List<PropertyDataDefinition> properties = group.getProperties();
 303         newGroupProperties.forEach(np -> {
 304             Optional<PropertyDataDefinition> currentProp = properties.stream().filter(p -> p.getName().equals(np.getName())).findAny();
 305             if (currentProp.isPresent()) {
 306                 currentProp.get().setValue(np.getValue());
 307                 currentProp.get().setToscaFunction(np.getToscaFunction());
 308             }
 309         });
 310         updateVersion(promoteMinorVersion, group);
 311         StorageOperationStatus updateDataRes = updateToscaDataOfToscaElement(componentVertex, EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS, group,
 312             JsonPresentationFields.CI_INVARIANT_NAME);
 313         if (updateDataRes != StorageOperationStatus.OK) {
 314             log.debug("Failed to update properties for group {} error {}", group.getName(), updateDataRes);
 315             return Either.right(updateDataRes);
 316         }
 317         componentVertex.setJsonMetadataField(JsonPresentationFields.LAST_UPDATE_DATE, System.currentTimeMillis());
 318         Either<GraphVertex, JanusGraphOperationStatus> updateRes = janusGraphDao.updateVertex(componentVertex);
 319         if (updateRes.isRight()) {
 320             CommonUtility.addRecordToLog(log, LogLevelEnum.DEBUG, "Failed to update the component {}. Status is {} ", componentId,
 321                 updateRes.right().value());
 322             return Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(updateRes.right().value()));
 323         }
 324         return Either.left(newGroupProperties);
 325     }
 326
 327     public Either<List<GroupInstance>, StorageOperationStatus> updateGroupInstances(Component component, String instanceId,
 328                                                                                     List<GroupInstance> updatedGroupInstances) {
 329         Either<List<GroupInstance>, StorageOperationStatus> result = null;
 330         StorageOperationStatus status = null;
 331         Either<GraphVertex, JanusGraphOperationStatus> getComponentVertex = janusGraphDao
 332             .getVertexById(component.getUniqueId(), JsonParseFlagEnum.NoParse);
 333         if (getComponentVertex.isRight()) {
 334             result = Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getComponentVertex.right().value()));
 335         }
 336         if (result == null) {
 337             List<String> pathKeys = new ArrayList<>();
 338             pathKeys.add(instanceId);
 339             status = updateToscaDataDeepElementsOfToscaElement(component.getUniqueId(), EdgeLabelEnum.INST_GROUPS, VertexTypeEnum.INST_GROUPS,
 340                 updatedGroupInstances, pathKeys, JsonPresentationFields.NAME);
 341             if (status != StorageOperationStatus.OK) {
 342                 result = Either.right(status);
 343             }
 344         }
 345         if (result == null) {
 346             result = Either.left(updatedGroupInstances);
 347         }
 348         return result;
 349     }
 350
 351     public Either<GroupDefinition, StorageOperationStatus> updateGroup(Component component, GroupDefinition currentGroup) {
 352         StorageOperationStatus status = updateToscaDataOfToscaElement(component.getUniqueId(), EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS,
 353             currentGroup, JsonPresentationFields.CI_INVARIANT_NAME);
 354         if (status != StorageOperationStatus.OK) {
 355             CommonUtility
 356                 .addRecordToLog(log, LogLevelEnum.DEBUG, "Failed to update group {} of component {}. The status is}. ", currentGroup.getName(),
 357                     component.getName(), status);
 358             return Either.right(status);
 359         }
 360         return Either.left(currentGroup);
 361     }
 362
 363     public StorageOperationStatus deleteGroup(Component component, String currentGroupName) {
 364         StorageOperationStatus status = deleteToscaDataElement(component.getUniqueId(), EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS, currentGroupName,
 365             JsonPresentationFields.CI_INVARIANT_NAME);
 366         if (status != StorageOperationStatus.OK) {
 367             CommonUtility.addRecordToLog(log, LogLevelEnum.DEBUG, "Failed to delete group {} of component {}. The status is}. ", currentGroupName,
 368                 component.getName(), status);
 369         }
 370         return status;
 371     }
 372
 373     public Either<GroupDefinition, StorageOperationStatus> addGroup(Component component, GroupDefinition currentGroup,
 374                                                                     PromoteVersionEnum promoteMinorVersion) {
 375         updateVersion(promoteMinorVersion, currentGroup);
 376         StorageOperationStatus status = addToscaDataToToscaElement(component.getUniqueId(), EdgeLabelEnum.GROUPS, VertexTypeEnum.GROUPS, currentGroup,
 377             JsonPresentationFields.CI_INVARIANT_NAME);
 378         if (status != StorageOperationStatus.OK) {
 379             CommonUtility
 380                 .addRecordToLog(log, LogLevelEnum.DEBUG, "Failed to update group {} of component {}. The status is}. ", currentGroup.getName(),
 381                     component.getName(), status);
 382             return Either.right(status);
 383         }
 384         return Either.left(currentGroup);
 385     }
 386
 387     public Either<GroupInstance, StorageOperationStatus> updateGroupInstancePropertyValuesOnGraph(String componentId, String instanceId,
 388                                                                                                   GroupInstance oldGroupInstance,
 389                                                                                                   List<GroupInstanceProperty> newProperties) {
 390         List<PropertyDataDefinition> propertiesOld = oldGroupInstance.getProperties();
 391         newProperties.forEach(np -> {
 392             Optional<PropertyDataDefinition> prop = propertiesOld.stream().filter(p -> p.getName().equals(np.getName())).findFirst();
 393             prop.ifPresent(propertyDataDefinition -> propertyDataDefinition.setValue(np.getValue()));
 394         });
 395         GroupInstanceDataDefinition groupInstanceDataDefinition = new GroupInstanceDataDefinition(oldGroupInstance);
 396         List<String> pathKeys = new ArrayList<>();
 397         groupInstanceDataDefinition.setModificationTime(System.currentTimeMillis());
 398         groupInstanceDataDefinition.setCustomizationUUID(UUID.randomUUID().toString());
 399         pathKeys.add(instanceId);
 400         StorageOperationStatus updateDataRes = updateToscaDataDeepElementOfToscaElement(componentId, EdgeLabelEnum.INST_GROUPS,
 401             VertexTypeEnum.INST_GROUPS, groupInstanceDataDefinition, pathKeys, JsonPresentationFields.NAME);
 402         if (updateDataRes != StorageOperationStatus.OK) {
 403             log.debug("Failed to update properties for group instance {} error {}", oldGroupInstance.getName(), updateDataRes);
 404             return Either.right(updateDataRes);
 405         }
 406         return Either.left(oldGroupInstance);
 407     }
 408 }