catalog-be/src/test/java/org/openecomp/sdc/be/components/validation/FilterConstraintValidatorImplTest.java

   1 /*
   2  * -
   3  *  ============LICENSE_START=======================================================
   4  *  Copyright (C) 2022 Nordix Foundation.
   5  *  ================================================================================
   6  *  Licensed under the Apache License, Version 2.0 (the "License");
   7  *  you may not use this file except in compliance with the License.
   8  *  You may obtain a copy of the License at
   9  *
  10  *       http://www.apache.org/licenses/LICENSE-2.0
  11  *
  12  *  Unless required by applicable law or agreed to in writing, software
  13  *  distributed under the License is distributed on an "AS IS" BASIS,
  14  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  15  *  See the License for the specific language governing permissions and
  16  *  limitations under the License.
  17  *
  18  *  SPDX-License-Identifier: Apache-2.0
  19  *  ============LICENSE_END=========================================================
  20  */
  21
  22 package org.openecomp.sdc.be.components.validation;
  23
  24 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
  25 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
  26 import static org.junit.jupiter.api.Assertions.assertEquals;
  27 import static org.junit.jupiter.api.Assertions.assertThrows;
  28
  29 import java.util.stream.Stream;
  30 import org.junit.jupiter.api.BeforeAll;
  31 import org.junit.jupiter.api.Test;
  32 import org.junit.jupiter.params.ParameterizedTest;
  33 import org.junit.jupiter.params.provider.Arguments;
  34 import org.junit.jupiter.params.provider.MethodSource;
  35 import org.openecomp.sdc.be.components.impl.exceptions.ByActionStatusComponentException;
  36 import org.openecomp.sdc.be.components.impl.exceptions.ComponentException;
  37 import org.openecomp.sdc.be.components.impl.exceptions.FilterConstraintExceptionSupplier;
  38 import org.openecomp.sdc.be.config.ConfigurationManager;
  39 import org.openecomp.sdc.be.datatypes.enums.ConstraintType;
  40 import org.openecomp.sdc.be.datatypes.enums.FilterValueType;
  41 import org.openecomp.sdc.be.datatypes.enums.PropertyFilterTargetType;
  42 import org.openecomp.sdc.be.model.dto.FilterConstraintDto;
  43 import org.openecomp.sdc.be.model.validation.FilterConstraintValidator;
  44 import org.openecomp.sdc.common.api.ConfigurationSource;
  45 import org.openecomp.sdc.common.impl.ExternalConfiguration;
  46 import org.openecomp.sdc.common.impl.FSConfigurationSource;
  47
  48 class FilterConstraintValidatorImplTest {
  49
  50     private final FilterConstraintValidator filterConstraintValidator = new FilterConstraintValidatorImpl();
  51
  52     @BeforeAll
  53     static void setUp() {
  54         String appConfigDir = "src/test/resources/config/catalog-be";
  55         ConfigurationSource configurationSource = new FSConfigurationSource(ExternalConfiguration.getChangeListener(), appConfigDir);
  56         new ConfigurationManager(configurationSource);
  57     }
  58
  59     @Test
  60     void validatePropertyFilterSuccess() {
  61         final FilterConstraintDto filterConstraintDto = buildFilterConstraintDto("aProperty", null, ConstraintType.EQUAL, FilterValueType.STATIC,
  62             PropertyFilterTargetType.PROPERTY, "any");
  63         assertDoesNotThrow(() -> filterConstraintValidator.validate(filterConstraintDto));
  64     }
  65
  66     @Test
  67     void validateCapabilityFilterSuccess() {
  68         final var filterConstraintDto = new FilterConstraintDto();
  69         filterConstraintDto.setCapabilityName("aCapability");
  70         filterConstraintDto.setPropertyName("aProperty");
  71         filterConstraintDto.setTargetType(PropertyFilterTargetType.CAPABILITY);
  72         filterConstraintDto.setOperator(ConstraintType.EQUAL);
  73         filterConstraintDto.setValueType(FilterValueType.STATIC);
  74         filterConstraintDto.setValue("any");
  75         assertDoesNotThrow(() -> filterConstraintValidator.validate(filterConstraintDto));
  76     }
  77
  78     @ParameterizedTest
  79     @MethodSource("provideMissingFieldParameters")
  80     void missingFieldError(FilterConstraintDto filterConstraintDto, ComponentException expectedException) {
  81         final ByActionStatusComponentException actualException =
  82             assertThrows(ByActionStatusComponentException.class, () -> filterConstraintValidator.validate(filterConstraintDto));
  83         assertEquals(actualException.getActionStatus(), expectedException.getActionStatus());
  84         assertArrayEquals(actualException.getParams(), expectedException.getParams());
  85     }
  86
  87     public static Stream<Arguments> provideMissingFieldParameters() {
  88         final var filterConstraintMissingValue = buildFilterConstraintDto("aProperty", null, ConstraintType.EQUAL, FilterValueType.STATIC, PropertyFilterTargetType.PROPERTY, null);
  89         final var filterConstraintMissingValueType = buildFilterConstraintDto("aProperty", null, ConstraintType.EQUAL, null, PropertyFilterTargetType.PROPERTY, "any");
  90         final var filterConstraintMissingPropertyName = buildFilterConstraintDto(null, null, ConstraintType.EQUAL, FilterValueType.STATIC, PropertyFilterTargetType.PROPERTY, "any");
  91         final var filterConstraintMissingCapabilityName = buildFilterConstraintDto("aProperty", null, ConstraintType.EQUAL, FilterValueType.STATIC, PropertyFilterTargetType.CAPABILITY, "any");
  92         final var filterConstraintMissingOperator = buildFilterConstraintDto("aProperty", null, null, FilterValueType.STATIC, PropertyFilterTargetType.PROPERTY, "any");
  93         final var filterConstraintMissingTargetType = buildFilterConstraintDto("aProperty", null, ConstraintType.EQUAL, FilterValueType.STATIC, null, "any");
  94
  95         return Stream.of(
  96             Arguments.of(filterConstraintMissingValue, FilterConstraintExceptionSupplier.missingField("value").get()),
  97             Arguments.of(filterConstraintMissingValueType, FilterConstraintExceptionSupplier.missingField("valueType").get()),
  98             Arguments.of(filterConstraintMissingPropertyName, FilterConstraintExceptionSupplier.missingField("propertyName").get()),
  99             Arguments.of(filterConstraintMissingCapabilityName, FilterConstraintExceptionSupplier.missingField("capabilityName").get()),
 100             Arguments.of(filterConstraintMissingOperator, FilterConstraintExceptionSupplier.missingField("operator").get()),
 101             Arguments.of(filterConstraintMissingTargetType, FilterConstraintExceptionSupplier.missingField("targetType").get())
 102         );
 103     }
 104
 105     @Test
 106     void validateNullFilterConstraint() {
 107         final ByActionStatusComponentException actualException = assertThrows(ByActionStatusComponentException.class,
 108             () -> filterConstraintValidator.validate(null));
 109         final ByActionStatusComponentException expectedException = FilterConstraintExceptionSupplier.filterConstraintNotProvided().get();
 110         assertEquals(actualException.getActionStatus(), expectedException.getActionStatus());
 111         assertArrayEquals(actualException.getParams(), expectedException.getParams());
 112     }
 113
 114     private static FilterConstraintDto buildFilterConstraintDto(String propertyName, String capabilityName, ConstraintType constraintType,
 115                                                                 FilterValueType filterValueType, PropertyFilterTargetType targetType, Object value) {
 116         final var filterConstraintMissingValueType = new FilterConstraintDto();
 117         filterConstraintMissingValueType.setPropertyName(propertyName);
 118         filterConstraintMissingValueType.setCapabilityName(capabilityName);
 119         filterConstraintMissingValueType.setTargetType(targetType);
 120         filterConstraintMissingValueType.setOperator(constraintType);
 121         filterConstraintMissingValueType.setValueType(filterValueType);
 122         filterConstraintMissingValueType.setValue(value);
 123         return filterConstraintMissingValueType;
 124     }
 125 }