catalog-be/src/test/java/org/openecomp/sdc/be/components/merge/policy/PoliciesMergeCommandTest.java

   1 /*-
   2  * ============LICENSE_START=======================================================
   3  * SDC
   4  * ================================================================================
   5  * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
   6  * ================================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ============LICENSE_END=========================================================
  19  */
  20
  21 package org.openecomp.sdc.be.components.merge.policy;
  22
  23 import com.google.common.collect.ImmutableMap;
  24 import org.junit.Before;
  25 import org.junit.Test;
  26 import org.junit.runner.RunWith;
  27 import org.mockito.ArgumentCaptor;
  28 import org.mockito.Captor;
  29 import org.mockito.InjectMocks;
  30 import org.mockito.Mock;
  31 import org.mockito.junit.MockitoJUnitRunner;
  32 import org.openecomp.sdc.be.components.utils.ComponentInstanceBuilder;
  33 import org.openecomp.sdc.be.components.utils.GroupDefinitionBuilder;
  34 import org.openecomp.sdc.be.components.utils.PolicyDefinitionBuilder;
  35 import org.openecomp.sdc.be.components.utils.ResourceBuilder;
  36 import org.openecomp.sdc.be.dao.api.ActionStatus;
  37 import org.openecomp.sdc.be.datatypes.elements.PolicyTargetType;
  38 import org.openecomp.sdc.be.impl.ComponentsUtils;
  39 import org.openecomp.sdc.be.model.ComponentInstance;
  40 import org.openecomp.sdc.be.model.GroupDefinition;
  41 import org.openecomp.sdc.be.model.PolicyDefinition;
  42 import org.openecomp.sdc.be.model.Resource;
  43 import org.openecomp.sdc.be.model.jsonjanusgraph.operations.ToscaOperationFacade;
  44 import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
  45
  46 import java.util.HashMap;
  47 import java.util.List;
  48 import java.util.Map;
  49
  50 import static java.util.Collections.emptyList;
  51 import static java.util.Collections.singletonList;
  52 import static org.assertj.core.api.Assertions.assertThat;
  53 import static org.mockito.ArgumentMatchers.anyList;
  54 import static org.mockito.ArgumentMatchers.eq;
  55 import static org.mockito.Mockito.verifyZeroInteractions;
  56 import static org.mockito.Mockito.when;
  57
  58 @RunWith(MockitoJUnitRunner.class)
  59 public class PoliciesMergeCommandTest {
  60
  61     private static final String CONTAINER_ID = "containerId";
  62     private static final String GROUP1 = "group1";
  63     private static final String GROUP1_ORIG_ID = GROUP1 + "Id";
  64     private static final String GROUP1_UPDATED_ID = GROUP1 +"NewId";
  65     private static final String GROUP2_ORIG_ID = "group2Id";
  66     private static final String INSTANCE1 = "instance1";
  67     private static final String INSTANCE1_ORIG_ID = INSTANCE1 + "Id";
  68     private static final String INSTANCE1_UPDATED_ID = INSTANCE1+ "NewId";
  69     private static final String INSTANCE2_ORIG_ID = "instance2Id";
  70     private static final Resource DONT_CARE = new Resource();
  71     @InjectMocks
  72     private PoliciesMergeCommand testInstance;
  73     @Mock
  74     private ToscaOperationFacade toscaOperationFacade;
  75     @Mock
  76     private ComponentsUtils componentsUtils;
  77     @Captor
  78     private ArgumentCaptor<List<PolicyDefinition>> policiesToMerge;
  79
  80     private PolicyDefinition noTargetsPolicy;
  81     private ComponentInstance instance1;
  82     private GroupDefinition group1;
  83     private Resource prevResource, newResource;
  84     private PolicyDefinition policy1;
  85
  86     @Before
  87     public void setUp() throws Exception {
  88         instance1 = new ComponentInstanceBuilder()
  89                 .setName(INSTANCE1)
  90                 .setId(INSTANCE1_UPDATED_ID)
  91                 .build();
  92         group1 = GroupDefinitionBuilder.create()
  93                 .setName(GROUP1 + "newName")
  94                 .setInvariantName(GROUP1)
  95                 .setUniqueId(GROUP1_UPDATED_ID)
  96                 .build();
  97         newResource = new ResourceBuilder()
  98                 .addGroup(group1)
  99                 .addComponentInstance(instance1)
 100                 .setUniqueId(CONTAINER_ID)
 101                 .build();
 102
 103         ComponentInstance prevInstance1 = new ComponentInstanceBuilder()
 104                 .setName(INSTANCE1)
 105                 .setId(INSTANCE1_ORIG_ID)
 106                 .build();
 107
 108         ComponentInstance prevInstance2 = new ComponentInstanceBuilder()
 109                 .setName(INSTANCE2_ORIG_ID)
 110                 .setId(INSTANCE2_ORIG_ID)
 111                 .build();
 112
 113         GroupDefinition prevGroup1 = GroupDefinitionBuilder.create()
 114                 .setName(GROUP1)
 115                 .setInvariantName(GROUP1)
 116                 .setUniqueId(GROUP1_ORIG_ID)
 117                 .build();
 118
 119         GroupDefinition prevGroup2 = GroupDefinitionBuilder.create()
 120                 .setName(GROUP2_ORIG_ID)
 121                 .setInvariantName(GROUP2_ORIG_ID)
 122                 .setUniqueId(GROUP2_ORIG_ID)
 123                 .build();
 124
 125         policy1 = PolicyDefinitionBuilder.create()
 126                 .addComponentInstanceTarget(prevInstance1.getUniqueId())
 127                 .addComponentInstanceTarget(prevInstance2.getUniqueId())
 128                 .addGroupTarget(prevGroup1.getUniqueId())
 129                 .addGroupTarget(prevGroup2.getUniqueId())
 130                 .setName("policy1")
 131                 .setUniqueId("policy1")
 132                 .build();
 133
 134         noTargetsPolicy = PolicyDefinitionBuilder.create()
 135                 .setUniqueId("policy2")
 136                 .setName("policy2")
 137                 .build();
 138
 139
 140         prevResource = new ResourceBuilder()
 141                 .addGroup(prevGroup1)
 142                 .addGroup(prevGroup2)
 143                 .addComponentInstance(prevInstance1)
 144                 .addComponentInstance(prevInstance2)
 145                 .build();
 146     }
 147
 148     @Test
 149     public void whenPreviousComponentHasNoPolicies_returnOk() {
 150         ActionStatus mergeResult = testInstance.mergeComponents(new Resource(), DONT_CARE);
 151         assertThat(mergeResult).isEqualTo(ActionStatus.OK);
 152         verifyZeroInteractions(toscaOperationFacade, componentsUtils);
 153     }
 154
 155     @Test
 156     public void associatePrevPoliciesToNewComponent() {
 157         prevResource = new ResourceBuilder()
 158                 .addPolicy(policy1)
 159                 .addPolicy(noTargetsPolicy)
 160                 .build();
 161         when(toscaOperationFacade.associatePoliciesToComponent(eq(CONTAINER_ID), policiesToMerge.capture())).thenReturn(StorageOperationStatus.OK);
 162         when(componentsUtils.convertFromStorageResponse(StorageOperationStatus.OK)).thenReturn(ActionStatus.OK);
 163         ActionStatus actionStatus = testInstance.mergeComponents(prevResource, newResource);
 164         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 165         List<PolicyDefinition> mergedPolicies = policiesToMerge.getValue();
 166         assertThat(mergedPolicies)
 167                 .containsExactlyInAnyOrder(policy1, noTargetsPolicy);
 168     }
 169
 170     @Test
 171     public void whenFailingToAssociatePolicies_propagateTheError() {
 172         prevResource = new ResourceBuilder()
 173                 .addPolicy(policy1)
 174                 .build();
 175         when(toscaOperationFacade.associatePoliciesToComponent(eq(CONTAINER_ID), anyList())).thenReturn(StorageOperationStatus.GENERAL_ERROR);
 176         when(componentsUtils.convertFromStorageResponse(StorageOperationStatus.GENERAL_ERROR)).thenReturn(ActionStatus.GENERAL_ERROR);
 177         ActionStatus actionStatus = testInstance.mergeComponents(prevResource, newResource);
 178         assertThat(actionStatus).isEqualTo(ActionStatus.GENERAL_ERROR);
 179     }
 180
 181     @Test
 182     public void whenPreviousPolicyTargetsDoesNotExistInNewVersion_ignoreTargets() {
 183         Map<PolicyTargetType, List<String>> expectedTargetsMap = createTargetsMap(singletonList(instance1.getUniqueId()), singletonList(group1.getUniqueId()));
 184         mergePolicies_verifyPoliciesTargets(policy1, expectedTargetsMap);
 185     }
 186
 187     @Test
 188     public void whenPrevPolicyGroupTargetNotExistInNewVersion_returnEmptyListInTargetMap() {
 189         PolicyDefinition policy = PolicyDefinitionBuilder.create()
 190                 .setName("policy")
 191                 .setUniqueId("policy")
 192                 .addGroupTarget(GROUP2_ORIG_ID)
 193                 .addComponentInstanceTarget(INSTANCE1_ORIG_ID)
 194                 .build();
 195         Map<PolicyTargetType, List<String>> expectedTargetsMap = createTargetsMap(singletonList(INSTANCE1_UPDATED_ID), emptyList());
 196         mergePolicies_verifyPoliciesTargets(policy, expectedTargetsMap);
 197     }
 198
 199     @Test
 200     public void whenPrevCapabilityInstanceTargetNotExistInNewVersion_returnEmptyListInTargetMap() {
 201         PolicyDefinition policy = PolicyDefinitionBuilder.create()
 202                 .setName("policy")
 203                 .setUniqueId("policy")
 204                 .addGroupTarget(GROUP1_ORIG_ID)
 205                 .addComponentInstanceTarget(INSTANCE2_ORIG_ID)
 206                 .build();
 207         Map<PolicyTargetType, List<String>> expectedTargetsMap = createTargetsMap(emptyList(), singletonList(GROUP1_UPDATED_ID));
 208         mergePolicies_verifyPoliciesTargets(policy, expectedTargetsMap);
 209     }
 210
 211     @Test
 212     public void whenPrevCapabilityInstanceAndGroupTargetsNotExistInNewVersion_returnTargetMapWithEmptyListsOfIds() {
 213         PolicyDefinition policy = PolicyDefinitionBuilder.create()
 214                 .setName("policy")
 215                 .setUniqueId("policy")
 216                 .addGroupTarget(GROUP2_ORIG_ID)
 217                 .addComponentInstanceTarget(INSTANCE2_ORIG_ID)
 218                 .build();
 219         Map<PolicyTargetType, List<String>> expectedTargetsMap = createTargetsMap(emptyList(), emptyList());
 220         mergePolicies_verifyPoliciesTargets(policy, expectedTargetsMap);
 221     }
 222
 223     @Test
 224     public void whenPrevCapabilityHasNoTargets_returnNullTargetsMap() {
 225         mergePolicies_verifyPoliciesTargets(noTargetsPolicy, null);
 226     }
 227
 228     private void mergePolicies_verifyPoliciesTargets(PolicyDefinition prevPolicy, Map<PolicyTargetType, List<String>> expectedTargetsMap) {
 229         prevResource.setPolicies(new HashMap<>());
 230         prevResource.getPolicies().put(prevPolicy.getUniqueId(), prevPolicy);
 231         when(toscaOperationFacade.associatePoliciesToComponent(eq(CONTAINER_ID), policiesToMerge.capture())).thenReturn(StorageOperationStatus.OK);
 232         when(componentsUtils.convertFromStorageResponse(StorageOperationStatus.OK)).thenReturn(ActionStatus.OK);
 233         ActionStatus actionStatus = testInstance.mergeComponents(prevResource, newResource);
 234         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 235         List<PolicyDefinition> mergedPolicies = policiesToMerge.getValue();
 236         assertThat(mergedPolicies)
 237                 .extracting("targets")
 238                 .containsExactlyInAnyOrder(expectedTargetsMap);
 239     }
 240
 241     private Map<PolicyTargetType, List<String>> createTargetsMap(List<String> cmptInstanceTargets, List<String> groupTargets) {
 242         return ImmutableMap.of(PolicyTargetType.COMPONENT_INSTANCES, cmptInstanceTargets, PolicyTargetType.GROUPS, groupTargets);
 243     }
 244
 245 }