catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/instance/GroupMembersUpdateOperationTest.java

   1 /*-
   2  * ============LICENSE_START=======================================================
   3  * SDC
   4  * ================================================================================
   5  * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
   6  * ================================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ============LICENSE_END=========================================================
  19  */
  20
  21 package org.openecomp.sdc.be.components.impl.instance;
  22
  23 import fj.data.Either;
  24 import org.junit.Before;
  25 import org.junit.Test;
  26 import org.junit.runner.RunWith;
  27 import org.mockito.ArgumentCaptor;
  28 import org.mockito.Captor;
  29 import org.mockito.Mock;
  30 import org.mockito.junit.MockitoJUnitRunner;
  31 import org.openecomp.sdc.be.auditing.impl.AuditingManager;
  32 import org.openecomp.sdc.be.components.impl.group.GroupMembersUpdater;
  33 import org.openecomp.sdc.be.components.utils.ComponentInstanceBuilder;
  34 import org.openecomp.sdc.be.components.utils.GroupDefinitionBuilder;
  35 import org.openecomp.sdc.be.components.utils.ResourceBuilder;
  36 import org.openecomp.sdc.be.dao.api.ActionStatus;
  37 import org.openecomp.sdc.be.datatypes.elements.GroupDataDefinition;
  38 import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum;
  39 import org.openecomp.sdc.be.datatypes.enums.PromoteVersionEnum;
  40 import org.openecomp.sdc.be.impl.ComponentsUtils;
  41 import org.openecomp.sdc.be.model.ComponentInstance;
  42 import org.openecomp.sdc.be.model.GroupDefinition;
  43 import org.openecomp.sdc.be.model.Resource;
  44 import org.openecomp.sdc.be.model.jsonjanusgraph.operations.GroupsOperation;
  45 import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
  46
  47 import java.util.ArrayList;
  48 import java.util.List;
  49 import java.util.stream.Stream;
  50
  51 import static java.util.Collections.emptyMap;
  52 import static org.assertj.core.api.Assertions.assertThat;
  53 import static org.mockito.ArgumentMatchers.any;
  54 import static org.mockito.ArgumentMatchers.anyList;
  55 import static org.mockito.ArgumentMatchers.eq;
  56 import static org.mockito.Mockito.mock;
  57 import static org.mockito.Mockito.when;
  58
  59 @RunWith(MockitoJUnitRunner.class)
  60 public class GroupMembersUpdateOperationTest {
  61
  62     private static final String CONTAINER_ID = "containerId";
  63     private static final String INSTANCE_ID_PRE_CHANGE = "inst2";
  64     private static final String INSTANCE_ID_POST_CHANGE = "newInst2";
  65     private GroupMembersUpdateOperation testInstance;
  66     @Mock
  67     private GroupsOperation groupsOperation;
  68     @Captor
  69     private ArgumentCaptor<List<GroupDataDefinition>> updatedGroupsCaptor;
  70     private GroupDefinition group1, group2, group3;
  71     private Resource container;
  72     private ComponentInstance prevInst2Version, currInst2Version;
  73     private static final ComponentInstance DONT_CARE_WHICH_INST = new ComponentInstance();
  74     private static final String DONT_CARE_WHICH_ID = "someString";
  75
  76     @Before
  77     public void setUp() throws Exception {
  78         testInstance = new GroupMembersUpdateOperation(groupsOperation, new ComponentsUtils(mock(AuditingManager.class)), new GroupMembersUpdater());
  79         group1 = createGroupWithMembers("group1", "inst1", INSTANCE_ID_PRE_CHANGE);
  80         group2 = createGroupWithMembers("group2", "inst1", INSTANCE_ID_PRE_CHANGE, "inst3");
  81         group3 = createGroupWithMembers("group3", "inst1", "inst3");
  82         container = new ResourceBuilder()
  83                 .addGroup(group1)
  84                 .addGroup(group2)
  85                 .setUniqueId(CONTAINER_ID)
  86                 .setComponentType(ComponentTypeEnum.RESOURCE)
  87                 .build();
  88         prevInst2Version = new ComponentInstanceBuilder()
  89                 .setId(INSTANCE_ID_PRE_CHANGE)
  90                 .build();
  91         currInst2Version = new ComponentInstanceBuilder()
  92                 .setId(INSTANCE_ID_POST_CHANGE)
  93                 .build();
  94     }
  95
  96     @Test
  97     public void onChangeVersion_whenNoGroupsOnContainer_returnOk() {
  98         ActionStatus actionStatus = testInstance.onChangeVersion(new Resource(), DONT_CARE_WHICH_INST, DONT_CARE_WHICH_INST);
  99         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 100     }
 101
 102     @Test
 103     public void onChangeVersion_whenEmptyListOfGroups_returnOk() {
 104         Resource resource = new Resource();
 105         resource.setGroups(new ArrayList<>());
 106         ActionStatus actionStatus = testInstance.onChangeVersion(resource, DONT_CARE_WHICH_INST, DONT_CARE_WHICH_INST);
 107         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 108     }
 109
 110     @Test
 111     public void onChangeVersion_whenGroupsHasNoMembers_returnOk() {
 112         GroupDefinition group1 = new GroupDefinition();
 113         group1.setMembers(emptyMap());
 114         GroupDefinition group2 = new GroupDefinition();
 115         group2.setMembers(emptyMap());
 116         Resource container = new ResourceBuilder()
 117                 .addGroup(group1)
 118                 .addGroup(group2)
 119                 .build();
 120         ComponentInstance prevInstance = new ComponentInstanceBuilder().setId("inst1").build();
 121         ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInstance, DONT_CARE_WHICH_INST);
 122         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 123     }
 124
 125     @Test
 126     public void onChangeVersion_whenPrevInstanceIsNotAMemberOfAnyGroup_returnOk() {
 127         ComponentInstance prevInstance = new ComponentInstanceBuilder().setId("nonMemberInst").build();
 128         ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInstance, DONT_CARE_WHICH_INST);
 129         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 130     }
 131
 132     @Test
 133     public void onChangeVersion_whenGroupHasPrevInstanceAsMember_replaceWithNewInstanceId_updateReplacedGroups() {
 134         verifyAllGroupsHasPrevInstancesAsMembers();
 135         when(groupsOperation.updateGroups(eq(container), updatedGroupsCaptor.capture(),any(PromoteVersionEnum.class))).thenReturn(Either.left(null));
 136         ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInst2Version, currInst2Version);
 137         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 138         assertUpdatedGroups(updatedGroupsCaptor.getValue(), group1, group2);
 139         verifyGroupWithPrevInstanceMemberWereReplaced();
 140     }
 141
 142     @Test
 143     public void onChangeVersion_whenFailingToUpdateGroups_propagateError() {
 144         when(groupsOperation.updateGroups(eq(container), updatedGroupsCaptor.capture(), any(PromoteVersionEnum.class))).thenReturn(Either.right(StorageOperationStatus.NOT_FOUND));
 145         ActionStatus actionStatus = testInstance.onChangeVersion(container, prevInst2Version, currInst2Version);
 146         assertThat(actionStatus).isEqualTo(ActionStatus.RESOURCE_NOT_FOUND);
 147     }
 148
 149     @Test
 150     public void onDeleteInstance_whenNoGroupsOnContainer_returnOk() {
 151         ActionStatus actionStatus = testInstance.onDelete(new Resource(), DONT_CARE_WHICH_ID);
 152         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 153     }
 154
 155     @Test
 156     public void onDeleteInstance_whenEmptyListOfGroups_returnOk() {
 157         Resource resource = new Resource();
 158         resource.setGroups(new ArrayList<>());
 159         ActionStatus actionStatus = testInstance.onDelete(resource, DONT_CARE_WHICH_ID);
 160         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 161     }
 162
 163     @Test
 164     public void onDeleteInstance_whenGroupsHasNoMembers_returnOk() {
 165         GroupDefinition group1 = new GroupDefinition();
 166         group1.setMembers(emptyMap());
 167         GroupDefinition group2 = new GroupDefinition();
 168         group2.setMembers(emptyMap());
 169         Resource container = new ResourceBuilder()
 170                 .addGroup(group1)
 171                 .addGroup(group2)
 172                 .build();
 173         ActionStatus actionStatus = testInstance.onDelete(container, "inst1");
 174         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 175     }
 176
 177     @Test
 178     public void onDeleteInstance_whenDeletedInstanceIsNotAMemberOfAnyGroup_returnOk() {
 179         ActionStatus actionStatus = testInstance.onDelete(container, "nonMemberInst");
 180         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 181     }
 182
 183     @Test
 184     public void onDeleteInstance_removeInstanceIdFromGroupMember() {
 185         when(groupsOperation.updateGroups(eq(container), updatedGroupsCaptor.capture(), any(PromoteVersionEnum.class))).thenReturn(Either.left(null));
 186         ActionStatus actionStatus = testInstance.onDelete(container, INSTANCE_ID_PRE_CHANGE);
 187         assertThat(actionStatus).isEqualTo(ActionStatus.OK);
 188         assertUpdatedGroups(updatedGroupsCaptor.getValue(), group1, group2);
 189         assertGroupMembersIds(group1, "inst1");
 190         assertGroupMembersIds(group2, "inst1", "inst3");
 191     }
 192
 193     @Test
 194     public void onDeleteInstance_whenGroupsUpdateFails_propagateTheFailure() {
 195         when(groupsOperation.updateGroups(eq(container), anyList(), any(PromoteVersionEnum.class))).thenReturn(Either.right(StorageOperationStatus.NOT_FOUND));
 196         ActionStatus actionStatus = testInstance.onDelete(container, INSTANCE_ID_PRE_CHANGE);
 197         assertThat(actionStatus).isEqualTo(ActionStatus.RESOURCE_NOT_FOUND);
 198     }
 199
 200     private void assertUpdatedGroups(List<GroupDataDefinition> actual, GroupDataDefinition ... expected) {
 201         assertThat(actual)
 202                 .containsExactlyInAnyOrder(expected);
 203     }
 204
 205     private void verifyGroupWithPrevInstanceMemberWereReplaced() {
 206         assertGroupMembersIds(group1, "inst1", INSTANCE_ID_POST_CHANGE);
 207         assertGroupMembersIds(group2, "inst1", INSTANCE_ID_POST_CHANGE, "inst3");
 208         assertGroupMembersIds(group3, "inst1", "inst3");
 209     }
 210
 211     private void verifyAllGroupsHasPrevInstancesAsMembers() {
 212         assertGroupMembersIds(group1, "inst1", INSTANCE_ID_PRE_CHANGE);
 213         assertGroupMembersIds(group2, "inst1", INSTANCE_ID_PRE_CHANGE, "inst3");
 214         assertGroupMembersIds(group3, "inst1", "inst3");
 215     }
 216
 217     private void assertGroupMembersIds(GroupDefinition group, String ... expectedMembersIds) {
 218         assertThat(group.getMembers())
 219                 .containsValues(expectedMembersIds);
 220     }
 221
 222     private GroupDefinition createGroupWithMembers(String groupId, String ... membersIds) {
 223         GroupDefinitionBuilder groupDefinitionBuilder = GroupDefinitionBuilder.create();
 224         Stream.of(membersIds).forEach(groupDefinitionBuilder::addMember);
 225         groupDefinitionBuilder.setUniqueId(groupId);
 226         return groupDefinitionBuilder.build();
 227     }
 228
 229 }